Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Book variants do not overwrite the skill they train (and overall status of AAA) #64408

Closed
GuardianDll opened this issue Mar 20, 2023 · 2 comments
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility

Comments

@GuardianDll
Copy link
Member

GuardianDll commented Mar 20, 2023

Describe the bug

Book variants do not overwrite the skill they train

Attach save file

N/A

Steps to reproduce

Spawn a Science of Revolutionary Warfare, see it has no driving skill
Check https://github.com/CleverRaven/Cataclysm-DDA/blob/master/data/json/items/book/driving.json#L236, see it has one
image

Expected behavior

Fix the variant skill inheritance
Change AAA Guide to train chemistry, and not driving skill
Split AAA Guide variants into separate books, with respected recipes (hard)

Versions and configuration

  • OS: Windows
  • OS Version: 10.0.19044.2728 (21H2)
  • Game Version: 72e5ffe [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Portal Storms Ignore NPCs [personal_portal_storms],
    No Fungal Growth [no_fungal_growth],
    Bionic Professions [package_bionic_professions]
    ]
@GuardianDll GuardianDll added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Mar 20, 2023
@anothersimulacrum
Copy link
Member

This isn't a thing variants can do, or that I would expect them to be capable of. I can look at why it's not reporting unvisited members for that.

@anothersimulacrum
Copy link
Member

Resolved in #64494

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility
Projects
None yet
Development

No branches or pull requests

2 participants