Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"you gives you a merch" message after delivering food to free merchant's broker #64071

Closed
gettingusedto opened this issue Mar 8, 2023 · 4 comments · Fixed by #68431
Closed
Labels
NPC / Factions NPCs, AI, Speech, Factions, Ownership (S2 - Confirmed) Bug that's been confirmed to exist

Comments

@gettingusedto
Copy link
Contributor

Describe the bug

The popup text that appears after delivering food to the broker says you gives you x merch instead of <npc_name> gives you x merch.

Attach save file

N/A

Steps to reproduce

  1. get yourself an item the broker can receive, like fruit wine and go to the refugee center,
  2. give the item to the broker through the dialogue,
  3. "you gives you a merch".

Expected behavior

The broker being the one that gives the money, not me going to their wallet and take a merch or two, that'd be rude.

Screenshots

Screenshot_20230309-054231

Versions and configuration

  • OS: Android
    • OS Version: Manufacturer: samsung; Model: SM-A710F; Release: 7.0; Incremental: A710FXXU2CRC2;
  • Game Version: 2f71c08 [32-bit]
  • Graphics Version: Tiles
  • Game Language: English [en]
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    No Fungal Growth [no_fungal_growth],
    Portal Storms Ignore NPCs [personal_portal_storms],
    No scent tracking zombies [no_scent_tracking_zombies],
    Magiclysm [magiclysm],
    Xedra Evolved [xedra_evolved],
    Misc Sprites [misc_sprite]
    ]

Additional context

No response

@gettingusedto gettingusedto added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Mar 8, 2023
@GuardianDll
Copy link
Member

Someone need to slap a new bool from #64070 into the broker json

@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Apr 8, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 8, 2023
@Procyonae
Copy link
Contributor

/confirm alef got this in a normal play session

@github-actions github-actions bot added (S2 - Confirmed) Bug that's been confirmed to exist and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels Jul 29, 2023
@SurFlurer
Copy link
Contributor

Cataclysm-DDA/src/npctalk.cpp

Lines 3444 to 3456 in 49c08f4

if( buyer_has == 1 ) {
//~ %1%s is the NPC name, %2$s is an item
popup( _( "%1$s gives you a %2$s." ), seller->disp_name(),
pay.tname() );
} else if( buyer_has > 1 ) {
//~ %1%s is the NPC name, %2$d is a number of items, %3$s are items
popup( _( "%1$s gives you %2$d %3$s." ), seller->disp_name(), buyer_has,
pay.tname() );
}
}
for( int i = 0; i < buyer_has; i++ ) {
seller->i_add( pay );
price -= value;

It's almost certain that it should be the buyer that gives currency to the seller 😄

@Maleclypse Maleclypse removed the stale Closed for lack of activity, but still valid. label Jul 29, 2023
@Maleclypse Maleclypse reopened this Jul 29, 2023
@Maleclypse Maleclypse added the NPC / Factions NPCs, AI, Speech, Factions, Ownership label Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPC / Factions NPCs, AI, Speech, Factions, Ownership (S2 - Confirmed) Bug that's been confirmed to exist
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants