Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some scores/achievements broken due to take over follower NPC upon death of starting character #63455

Closed
cake-pie opened this issue Feb 6, 2023 · 1 comment · Fixed by #63488
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility stale Closed for lack of activity, but still valid.

Comments

@cake-pie
Copy link
Contributor

cake-pie commented Feb 6, 2023

Describe the bug

Some scores and achievements rely on event statistics that perform a comparison against avatar_id, as a check to determine whether it was the player character (as opposed to some other NPC) who did/attained something. This avatar_id is recorded from the starting character upon game_start event.

If your starting character dies and you take control of a follower NPC, the stats break because the player character now has a different character ID.

Attach save file

N/A -- bug identified by code inspection

Steps to reproduce

  1. Start a new game as a survivor in evac shelter
  2. Make the shelter NPC into a follower
  3. Check score screen for "0 monsters killed"
  4. Debug spawn a suitable weapon
  5. Debug spawn a chicken
  6. Kill the chicken, and check score increased to 1 kill
  7. Debug to cause yourself a bunch of damage, then spawn a ladder, climb on the roof and walk off it
  8. Die from fall, take over the NPC
  9. Grab the weapon, spawn a chicken, kill it
  10. Kill count on score tab has stopped incrementing. Kill count on kills tab still works, though

Expected behavior

Either:

All scores, achievements and conducts accrued so far continue to count and continue to be updated with respect to the new player character.

or

All scores, achievements and conducts are reset upon death and take over of a new character.

Screenshots

No response

Versions and configuration

Bug reproduced in 4b6270c

Additional context

No response

@cake-pie cake-pie added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Feb 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility stale Closed for lack of activity, but still valid.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant