Processor boards dropped by Milspec Searchlights don't group with other ones or themselves

[anoobindisguise]

Describe the bug

Processor boards dropped by Milspec Searchlights don't group together with processor boards obtained through other methods or other processor boards dropped by searchlights, creating bloated item lists that must be pagedowned through if the player accumulates many processor boards.

Steps to reproduce

1. Debug spawn a bunch of processor boards.
2. Debug spawn a bunch of milspec searchlights.
3. Kill the milspec searchlights.
4. Lump the milspec searchlight processor boards in with the "normal" processor boards.
5. Observe them forming dozens of separate piles: 1 single pile for all the "normal" processor boards, and dozens of individual 1-2 piles of processor boards.

Expected behavior

Processor boards from milspec searchlights should group together with other processor boards and themselves.

Screenshots

No response

Versions and configuration

• OS: Windows
  • OS Version: 10.0.22000.1455 (21H2)
• Game Version: f097346 [64-bit]
• Graphics Version: Tiles
• Game Language: System language []
• Mods loaded: [
  Dark Days Ahead [dda],
  Disable NPC Needs [no_npc_food],
  No Fungal Growth [no_fungal_growth],
  Bionic Professions [package_bionic_professions]
  ]

Additional context

No response

[andrei8l]

/confirmed The variables used by the searchlight code aren't cleared on death

Cataclysm-DDA/src/monattack.cpp

Lines 3841 to 3867 in b483a88

	for( int i = 0; i < max_lamp_count; i++ ) {
	item &settings = z->inv[i];
	if( settings.get_var( "SL_POWER" ) == "OFF" ) {
	return true;
	}
	const int rng_dir = rng( 0, 7 );
	if( one_in( 5 ) ) {
	if( !one_in( 5 ) ) {
	settings.set_var( "SL_DIR", rng_dir );
	} else {
	const int rng_pref = rng( 0, 3 );
	static const std::array<std::string, 4> settings_names = {{
	"SL_PREFER_UP", "SL_PREFER_RIGHT", "SL_PREFER_DOWN", "SL_PREFER_LEFT"
	}
	};
	if( settings.get_var( settings_names[rng_pref] ) == "TRUE" ) {
	settings.set_var( "SL_DIR", rng_pref * 2 );
	}
	}
	}
	point p( zpos + point( settings.get_var( "SL_SPOT_X", 0 ), settings.get_var( "SL_SPOT_Y", 0 ) ) );