Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMMO with reversible craft will only give default disassembly #62892

Closed
flybye3o6 opened this issue Dec 27, 2022 · 6 comments
Closed

AMMO with reversible craft will only give default disassembly #62892

flybye3o6 opened this issue Dec 27, 2022 · 6 comments
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility stale Closed for lack of activity, but still valid.

Comments

@flybye3o6
Copy link
Contributor

flybye3o6 commented Dec 27, 2022

Describe the bug

ammo with reversible craft will only give the first listed craft items when disassembling

Steps to reproduce

make an acid bomb with 2 glass flasks, 2 hydrochloric acid, and 50 plant fiber
disassembly will yield 1 0.5L glass jar, 2 sulfuric acid, 1 short string

Expected behavior

disassembly returns only the items used in craft
or remove "reversible": true from ammo crafts that use a choice of components
or idk something so i can pass uncraft tests

Screenshots

the craft
image
the resulting item
image
this causes test failures
image

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.19044.2364 (21H2)
  • Game Version: b3b97e0 [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    No Fungal Growth [no_fungal_growth],
    Bionic Professions [package_bionic_professions]
    ]

Additional context

changing acidbomb "type": "AMMO" to "TOOL" gave this result and could be disassembled back into its parts(not a fix)
image
image

@flybye3o6 flybye3o6 added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Dec 27, 2022
@flybye3o6 flybye3o6 mentioned this issue Dec 27, 2022
@mqrause
Copy link
Contributor

mqrause commented Dec 27, 2022

count_by_charges items currently don't store their components, so they'll always fall back to default components. That's because there might be issues with distributing components evenly to charges. So there's two ways to solve this.

  1. Make ammo not count_by_charges anymore. This will happen but probably take a while.
  2. Use the improvements from Refactor item components to be stored as a map #62498 and Remove charges from solid comestibles #60885 to enforce components to be multiples of charges and then also store components for count_by_charges items. Still means waiting for those, but should be a fairly small change after that. Could also be done independently of those, but might be more issue-prone.

@flybye3o6
Copy link
Contributor Author

flybye3o6 commented Dec 27, 2022

quick fix i can do for my needs, its hacky and i dont like it but the molotov cocktail already does this
would be to change acid bomb type to TOOL and make a sling ready acid bomb and make that AMMO
rn ill just wait because i dont need anything until after next stable, and i dont want to add something just to reverse it latter
i was looking for other items effected by this and all i found was baseball im sure there are other items but its likely to be a small list

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Jan 26, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 25, 2023
@LyleSY
Copy link
Contributor

LyleSY commented Mar 3, 2023

Not fixed yet

@LyleSY LyleSY reopened this Mar 3, 2023
@github-actions github-actions bot removed the stale Closed for lack of activity, but still valid. label Mar 3, 2023
@flybye3o6
Copy link
Contributor Author

when this is fixed "reversible": true will need to be added back into acidbomb recipe

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Apr 3, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility stale Closed for lack of activity, but still valid.
Projects
None yet
Development

No branches or pull requests

3 participants