Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPAWN_GROUP spell effect doesn't work with item_group #61884

Closed
GuardianDll opened this issue Oct 23, 2022 · 2 comments
Closed

SPAWN_GROUP spell effect doesn't work with item_group #61884

GuardianDll opened this issue Oct 23, 2022 · 2 comments
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility stale Closed for lack of activity, but still valid.

Comments

@GuardianDll
Copy link
Member

Describe the bug

SPAWN_GROUP spell effect doesn't work with item_group, even when the doc says the opposite

Steps to reproduce

1. Copypaste the json below
  {
    "id": "innamagic_animsit_scroll_spawn",
    "type": "SPELL",
    "name": "Spawn Animist Scroll",
    "description": "Spawns a random animist scroll from group.",
    "valid_targets": [ "self" ],
    "min_damage": 1,
    "max_damage": 1,
    "effect": "spawn_item",
    "effect_str": "animist_scrolls",
    "shape": "blast",
    "min_duration": 17280000,
    "max_duration": 69120000,
    "flags": [ "SPAWN_GROUP", "SILENT", "RANDOM_DURATION" ]
  },
  {
    "type": "item_group",
    "id": "animist_scrolls",
    "items": [
      { "item": "spell_scroll_banishment_lesser", "prob": 100 },
      { "item": "spell_scroll_bleed", "prob": 100 },
      { "item": "spell_scroll_boneclub", "prob": 100 },
      { "item": "spell_scroll_disruption_bolt", "prob": 100 }
    ]
  }
  1. Cast a Spawn Animist Scroll spell
  2. Find it triggers error, and spawn undefined-animist_scrolls item

Expected behavior

Spawn a random item from loot group
Same ability for EoC would be also good (especially good if there would be a counter to not repeat himself)

Screenshots

DEBUG    : Missing item definition: animist_scrolls

FUNCTION : find_template
FILE     : D:\a\Cataclysm-DDA\Cataclysm-DDA\src\item_factory.cpp
LINE     : 2367
VERSION  : 26a4725

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.19044.2130 (21H2)
  • Game Version: 26a4725 [64-bit]
  • Graphics Version: Tiles
  • Game Language: English [en]
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    No Fungal Growth [no_fungal_growth],
    Bionic Professions [package_bionic_professions],
    Magiclysm [magiclysm],
    Xedra Evolved [xedra_evolved],
    Mythical Martial Arts [MMA]
    ]

Additional context

No response

@GuardianDll GuardianDll added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Oct 23, 2022
@ZhilkinSerg
Copy link
Contributor

Item spawn from item group was not implemented as mentioned in #40656. Someone is yet to do that.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Dec 7, 2022
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility stale Closed for lack of activity, but still valid.
Projects
None yet
Development

No branches or pull requests

2 participants