lost keypress on Wayland

[schauveau]

Describe the bug

I am running a recent git version as a Wayland application. Everything appears to works fine except that pressed keys are not always detected when a key was already pressed. It is as if a key release event was invalidating all keys that are currently pressed.

Steps to reproduce

1. Start CDDA as a native Wayland application by setting SDL_VIDEODRIVER=wayland
2. Load a game and position the character so that it can move freely
3. Press the RIGHT key.
4. Press the LEFT key while keeping the RIGHT key pressed.
5. Release the RIGHT key while keeping the LEFT key pressed.

The character stops moving even though the LEFT key is still pressed.

Expected behavior

The character should start moving to the LEFT

The X11 version does that which is, imho, the correct behavior.

Screenshots

No response

Versions and configuration

• OS: Linux
  • OS Version: Distributor ID: Debian; Description: Debian GNU/Linux bookworm/sid; Release: unstable; Codename: sid;
  • Wayland Compositor: Sway
• Game Version: 0.F-11358-gcdcb0713fe [64-bit]
• Graphics Version: Tiles
• Game Language: English [en]
• Mods loaded: [
  Dark Days Ahead [dda],
  Disable NPC Needs [no_npc_food],
  No Fungal Growth [no_fungal_growth],
  Bionic Professions [package_bionic_professions],
  sees-player, run, crouch, bleed icons, retrodays [sees_player_retro]
  ]

Additional context

No response

[ZhilkinSerg]

This is probably something to be fixed in SDL/Wayland.

[schauveau]

Probably! I can reproduce the behavior with this small SDL code.
sdlkey.cc.txt
I will search in the SDL bug reports.

[sonphantrung]

As the issue mentioned above is now closed, should we also close this?

[ThePeiLin]

It is still an issue in the experimental build 2022-12-09-0649

[ZhilkinSerg]

It is still an issue in the experimental build 2022-12-09-0649

It depends on which SDL version you will use to compile the game.

[ThePeiLin]

Deleting or commenting line 3205 of the file sdltiles.cpp might solve this issue, but I don't know if that would cause any other problems.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.