Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method to know that HELMET_MANDIBLE_GUARD_STRAPPED and HELMET_MANDIBLE_GUARD are different in game #60086

Closed
chrispikula opened this issue Aug 11, 2022 · 1 comment · Fixed by #60984
Labels
<Suggestion / Discussion> Talk it out before implementing

Comments

@chrispikula
Copy link
Contributor

chrispikula commented Aug 11, 2022

Is your feature request related to a problem? Please describe.

For the helmet attachments, specifically, mandible guards, there are two types.

As it stands, other than the item itself saying it fits in hard hats and helmets, there is no indication that it doesn't fit in helmets (military).
image

Solution you would like.

They weren't merged into one in the original PRs, but I couldn't find a reason why?
#58749
#58020

If there's a reason not to, could there be a way to say that they aren't compatible, rather than having to search *.json?

Describe alternatives you have considered.

No response

Additional context

Example of two incompatible mandible items:

Plastic Chin Guard:
image
Tactical Helmet:
image

@chrispikula chrispikula added the <Suggestion / Discussion> Talk it out before implementing label Aug 11, 2022
@Termineitor244
Copy link
Contributor

So, here is the thing, the reason there are 2 different flags for the mandible guards is that they are supposed to represent 2 different kinds of mandible guards, one being the military rail mounted kind and the other just an attachment made with straps for any common hard hat or helmet.

I should had probably done a change so this was more clear in-game, but I had too much work after my last PR in which I added these new items so it slipped me by, sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Suggestion / Discussion> Talk it out before implementing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants