Blacksmith Cody Miller & Gunsmith Jay Ruckers non-unique

[deafmole]

Describe the bug

The 'unique' NPC-Location is not unique. While it is understandable that we should encounter that location, it leads to silly mapgeneration like you can see below.

Steps to reproduce

1. Start a new run
2. Explore

Expected behavior

• The Location gets only generated once.
• Alternatively, add a set of the NPCs & their different quests
• No call_by_reference for (unique) NPCs.

Screenshots

Versions and configuration

• OS: Windows
  • OS Version: 10.0.19043.1766 (21H1)
• Game Version: 27817a3 [64-bit]
• Graphics Version: Tiles
• Game Language: English [en]
• Mods loaded: [
  Dark Days Ahead [dda],
  Disable NPC Needs [no_npc_food],
  Bionic Professions [package_bionic_professions],
  No Rail Stations [No_Rail_Stations]
  ]

Additional context

No response

[andrei8l]

This is a known issue with no good solution at the moment. You can read through previous discussion in #49322 and #57127.

[deafmole]

Oh, sorry I just checked for the Blacksmith location in issues. Never encountered them before, so I thought that might be an issue with the definition of that single location. And I have never found more than one Hub, one Refugeecenter, etc.. - however, I am not a mobile-base-player.
If a globally unique flag, like mentioned in #49322 is used, adding NPCs to it shouldn't be too hard.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

[kevingranade]

Duplicate of more general issue.