Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPC label does not apply correctly #57994

Closed
NetSysFire opened this issue May 29, 2022 · 0 comments · Fixed by #58000
Closed

NPC label does not apply correctly #57994

NetSysFire opened this issue May 29, 2022 · 0 comments · Fixed by #58000
Labels
<Bug> This needs to be fixed Code: Tooling Tooling that is not part of the main game but is part of the repo.

Comments

@NetSysFire
Copy link
Member

Describe the bug

Looking at https://github.com/CleverRaven/Cataclysm-DDA/pull/57993/files, I had to apply the NPC label manually.

Steps to reproduce

n/a

Expected behavior

Label gets applied.

There is

"NPC / Factions":
- "**/npc**"

But it appears it will only match files? I actually tried fixing this on my own but I do not know enough about these patterns. Maybe it needs to be **/npc/**/* but I am not sure at all.

CC @Maleclypse because they have been working on the labeler.

Screenshots

No response

Versions and configuration

Additional context

Another thing that I was pondering about is that perhaps the bugfix label could also get applied when a closing keyword is detected. summary-labels.yml already does something very similar but would need to match (Fixes|Closes) etc.

@NetSysFire NetSysFire added <Bug> This needs to be fixed Code: Tooling Tooling that is not part of the main game but is part of the repo. labels May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Code: Tooling Tooling that is not part of the main game but is part of the repo.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant