Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge case when manually spawning map extras adjacent to the player #53830

Closed
NetSysFire opened this issue Dec 28, 2021 · 4 comments · Fixed by #55299
Closed

Edge case when manually spawning map extras adjacent to the player #53830

NetSysFire opened this issue Dec 28, 2021 · 4 comments · Fixed by #55299
Labels
<Bug> This needs to be fixed Code: Debug Debugging and troubleshooting the game, also includes the debug menu Map / Mapgen Overmap, Mapgen, Map extras, Map display

Comments

@NetSysFire
Copy link
Member

Describe the bug

There is an (apparently literal) edge case where spawning a map extra adjacent to the player via the debug menu yields an error.

Steps to reproduce

  1. Create a new world.
  2. Spawn a map extra (I used mx_crater) one overmap tile away so it is still in your field of vision.
  3. Witness an error
 DEBUG    : loading non-main map at (-1130,924,0) which overlaps with main map (abs_sub = (-1135,922,0)) is not supported

 FUNCTION : void map::load(const tripoint_abs_sm&, bool, bool)
 FILE     : src/map.cpp
 LINE     : 6624
 VERSION  : 0.F

Expected behavior

No error. The map extra appears to be generated correctly though.

Screenshots

No response

Versions and configuration

  • experimental (from 2021-12-21)

Additional context

No response

@NetSysFire NetSysFire added <Bug> This needs to be fixed Map / Mapgen Overmap, Mapgen, Map extras, Map display Code: Debug Debugging and troubleshooting the game, also includes the debug menu labels Dec 28, 2021
@Night-Pryanik
Copy link
Contributor

I can confirm this error, though it pops even if I spawn map extra far away from my character's position.

@a-chancey
Copy link
Contributor

I get the same error when building faction camp expansions currently

@NetSysFire
Copy link
Member Author

Does it still work or does the error break it?

@a-chancey
Copy link
Contributor

a-chancey commented Dec 30, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Code: Debug Debugging and troubleshooting the game, also includes the debug menu Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants