Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acid Anthills don't yet spawn #53517

Closed
Holli-Git opened this issue Dec 17, 2021 · 5 comments · Fixed by #60095
Closed

Acid Anthills don't yet spawn #53517

Holli-Git opened this issue Dec 17, 2021 · 5 comments · Fixed by #60095
Labels
Map / Mapgen Overmap, Mapgen, Map extras, Map display (P5 - Long-term) Long-term WIP, may stay on the list for a while.

Comments

@Holli-Git
Copy link
Contributor

Describe the bug

Acid anthills don't spawn.

Steps to reproduce

There's code that specifically states acid anthills don't spawn.

Expected behavior

I expect acid anthills to spawn

Screenshots

No response

Versions and configuration

  • OS: Windows
    • OS Version: 10.0 2009
  • Game Version: 03f9cc1 [64-bit]
  • Graphics Version: Tiles
  • Game Language: Nederlands [nl]
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    No Fungal Growth [no_fungal_growth],
    Bionic Professions [package_bionic_professions]
    ]

Additional context

Related to #51474 , got permission from Maleclypse to make an issue about it even with the original PR author planning on adding it back so that more people could work on it.

@Night-Pryanik Night-Pryanik added the Map / Mapgen Overmap, Mapgen, Map extras, Map display label Dec 17, 2021
@jbytheway
Copy link
Contributor

Since I've let this lack of Acid Anthills go one much longer than I originally intended I will explain a bit more about how I envisioned re-adding them.

I wanted to be able to reuse the existing JSON maps for the non-acid anthill. But obviously they need different creatures in them. So, I was planning to take advantage of mapgen parameters to specify the category of ants present.

However, some of the monsters are defined at the OMT level, and there's currently no support for mapgen parameters at the OMT level, so this was waiting on that to be added.

@Holli-Git
Copy link
Contributor Author

Since I've let this lack of Acid Anthills go one much longer than I originally intended I will explain a bit more about how I envisioned re-adding them.

I wanted to be able to reuse the existing JSON maps for the non-acid anthill. But obviously they need different creatures in them. So, I was planning to take advantage of mapgen parameters to specify the category of ants present.

However, some of the monsters are defined at the OMT level, and there's currently no support for mapgen parameters at the OMT level, so this was waiting on that to be added.

No worries! Take your time lmao, I just put this up so that it could get a bit more attention. Sorry if I put any unneeded pressure on you!

@Inglonias
Copy link
Contributor

Honestly, I don't miss acid anthills at all. In my experience they're just a giant "no-go" zone on the map, similar to how fungus can be.

@Holli-Git
Copy link
Contributor Author

Honestly, I don't miss acid anthills at all. In my experience they're just a giant "no-go" zone on the map, similar to how fungus can be.

Biosilicified chitin is some of the most powerful armour you can get

@stale
Copy link

stale bot commented Apr 19, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@stale stale bot added the stale Closed for lack of activity, but still valid. label Apr 19, 2022
@Maleclypse Maleclypse added the (P5 - Long-term) Long-term WIP, may stay on the list for a while. label Aug 9, 2022
@stale stale bot removed the stale Closed for lack of activity, but still valid. label Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Map / Mapgen Overmap, Mapgen, Map extras, Map display (P5 - Long-term) Long-term WIP, may stay on the list for a while.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants