Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part list is almost fully invisible when attempting to install a vehicle part #52447

Closed
Ilysen opened this issue Oct 26, 2021 · 1 comment · Fixed by #52469
Closed

Part list is almost fully invisible when attempting to install a vehicle part #52447

Ilysen opened this issue Oct 26, 2021 · 1 comment · Fixed by #52469
Labels
Info / User Interface Game - player communication, menus, etc. Vehicles Vehicles, parts, mechanics & interactions

Comments

@Ilysen
Copy link
Contributor

Ilysen commented Oct 26, 2021

Describe the bug

When trying to install a part onto any vehicle tile, the list of part options is completely invisible on most tiles. External tiles are invisible except for a "fridge" part. You can still use the arrow keys and search function to navigate to and select parts, but it has to be done by looking at the info on the sidebar.

Steps To Reproduce

  1. Find an existing vehicle, or debug one in.
  2. examine the vehicle, try to install a part on any of that vehicle's tiles.
  3. See that the part list is completely empty for the interior of vehicles, or only shows the fridge for exterior/empty tiles.

Expected behavior

All possible parts should be visible when attempting to install a vehicle part.

Screenshots

image
cataclysm-tiles_WGAvl7wKB1

Versions and configuration

Note - I compiled this from source. My diff tree is empty except for a .manifest file, and my branch is otherwise up-to-date with master as of the time of posting. No changes have been made to the C++ code, and the solution was only opened to compile.

  • OS: Windows
    • OS Version: 10.0 2009
  • Game Version: 0.F-3579-g43f9c3cbd1 [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [
    Dark Days Ahead [dda],
    Blaze Industries [blazeindustries],
    No Rail Stations [No_Rail_Stations],
    Bionic Slots [cbm_slots],
    Disable NPC Needs [no_npc_food],
    No Fungal Growth [no_fungal_growth]
    ]

Additional context

If I had to guess, this is probably related to #51286, but I have no idea.

@dseguin
Copy link
Member

dseguin commented Oct 26, 2021

Any vehicle part without the "APPLIANCE" flag is skipped when printing (from 9a356d9):

for( size_t i = page * lines_per_page; i < ( page + 1 ) * lines_per_page && i < list.size(); i++ ) {
const vpart_info &info = *list[i];
if( !info.has_flag( VPFLAG_APPLIANCE ) ) {
continue;
}
int y = i - page * lines_per_page + header;
mvwputch( w_list, point( 1, y ), info.color, special_symbol( info.sym ) );
nc_color col = can_potentially_install( info ) ? c_white : c_dark_gray;
trim_and_print( w_list, point( 3, y ), getmaxx( w_list ) - 3, pos == i ? hilite( col ) : col,
info.name() );
}

@BrettDong BrettDong added Info / User Interface Game - player communication, menus, etc. Vehicles Vehicles, parts, mechanics & interactions labels Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Info / User Interface Game - player communication, menus, etc. Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants