Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anti-glare compensators not working with acetylene torch #52276

Closed
Torres84f opened this issue Oct 13, 2021 · 7 comments · Fixed by #52292
Closed

Anti-glare compensators not working with acetylene torch #52276

Torres84f opened this issue Oct 13, 2021 · 7 comments · Fixed by #52292
Labels
<Bug> This needs to be fixed Items / Item Actions / Item Qualities Items and how they work and interact

Comments

@Torres84f
Copy link

Describe the bug

The CBM description says that it works as welding goggles and you can work with any welding equipment except for the task of bringing down a shut tight metal door, if you have a working acetylene torch and you try and take said door down a message pops saying you need goggles for that -_-

Steps To Reproduce

1.- Install said CBM
2.- Try and use the acetylene torch to destroy/unweld a metal door
3.- A message pops up saying you need welding goggles to do that

Expected behavior

Should work as the description says

Screenshots

No response

Versions and configuration

  • OS: Windows
    • OS Version: 10.0 2009
  • Game Version: 1d946db [64-bit]
  • Graphics Version: Tiles
  • Game Language: English [en]
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Bionic Professions [package_bionic_professions],
    Aftershock [aftershock],
    Blaze Industries [blazeindustries],
    C.R.I.T Expansion Mod [crt_expansion],
    Magiclysm [magiclysm],
    DinoMod [DinoMod],
    Aftershock - UndeadPeople Tileset [AftershockUDP],
    Blaze Industries - UndeadPeople Tileset [BlazeIndustriesUDP],
    C.R.I.T Expansion Mod - UndeadPeople Tileset [crt_expansionUDP],
    DinoMod - UndeadPeople Tileset [DinoModUDP],
    Graphical Overmap [Graphical_Overmap],
    Graphical Overmap Magiclysm [Graphical_Overmap_Magiclysm],
    Magiclysm - UndeadPeople Tileset [MagiclysmUDP],
    SpeedyDex [speedydex],
    Stats Through Kills [stats_through_kills],
    Stats Through Skills [StatsThroughSkills],
    Useful Helicopters [useful_helicopters]
    ]

Additional context

No response

@Saicchi
Copy link
Contributor

Saicchi commented Oct 13, 2021

Item fake_goggles has a GLARE quality of 1, but for welding a GLARE quality of at least 2 is required.

{
"id": "fake_goggles",
"copy-from": "fake_item",
"type": "TOOL",
"name": { "str_sp": "bionic goggles" },
"qualities": [ [ "GLARE", 1 ] ]
},

@Torres84f
Copy link
Author

Item fake_goggles has a GLARE quality of 1, but for welding a GLARE quality of at least 2 is required.

{
"id": "fake_goggles",
"copy-from": "fake_item",
"type": "TOOL",
"name": { "str_sp": "bionic goggles" },
"qualities": [ [ "GLARE", 1 ] ]
},

shouldn't it be 2? I mean it literally says it protects your eyes for that specific task or perhaps lower the need for glare protection for that task to 1?

What I mean is that I can do literally any and all welding jobs except for that one with the acetylene torch and taking down metal doors.

@Saicchi
Copy link
Contributor

Saicchi commented Oct 14, 2021

Yes. It should be 2.

@KacperRaid
Copy link

KacperRaid commented Oct 14, 2021

Yea, i have same problem, #52146 probably left requirement for cutting metal doors down with torch at glare 2 instead of intended 1.

@Saicchi
Copy link
Contributor

Saicchi commented Oct 14, 2021

Then since the requirements for welding changed.

if( !p->has_quality( GLARE, 2 ) ) {

Set the minimum required level to 1

@Vhari-Maven
Copy link

I don't think this issue is limited to the CBM. I'm having issues using the acetylene torch to open metal doors even with regular welding goggles in my inventory. I get the same message when I try: "you need welding goggles to do that".

@Saicchi
Copy link
Contributor

Saicchi commented Oct 15, 2021

The issue referenced by KacperRaid two above you only changed the welding requirements for crafting, it did not change the requirements for using the oxytorch.
The linked PR will fix those issues.

@wapcaplet wapcaplet added <Bug> This needs to be fixed Items / Item Actions / Item Qualities Items and how they work and interact labels Oct 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Items / Item Actions / Item Qualities Items and how they work and interact
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants