Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPC's issues with backpacks #52250

Closed
Torres84f opened this issue Oct 11, 2021 · 3 comments · Fixed by #52261
Closed

NPC's issues with backpacks #52250

Torres84f opened this issue Oct 11, 2021 · 3 comments · Fixed by #52261
Labels
<Bug> This needs to be fixed Items: Containers Things that hold other things NPC / Factions NPCs, AI, Speech, Factions, Ownership (S2 - Confirmed) Bug that's been confirmed to exist

Comments

@Torres84f
Copy link

Describe the bug

NPC's are not equipping correctly the backpacks I give them, tried with many different backpacks and when you use the trade screen to give them stuff like bandages to carry they're always at ZERO volume capacity so they tell you they don't have room for that even though the backpack is equipped and they carry nothing else.

Steps To Reproduce

1.- Spawn friendly NPC
2.- Get them naked
3.- Equip them a backpack
4.- It won't add carry volume for them so they won't accept anything else

Expected behavior

It should add the backpack value to their inventory or at least the pockets available.

Screenshots

No response

Versions and configuration

  • OS: Windows
    • OS Version: 10.0 2009
  • Game Version: 8256058 [64-bit]
  • Graphics Version: Tiles
  • Game Language: English [en]
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Bionic Professions [package_bionic_professions],
    Aftershock [aftershock],
    Blaze Industries [blazeindustries],
    C.R.I.T Expansion Mod [crt_expansion],
    Magiclysm [magiclysm],
    DinoMod [DinoMod],
    Aftershock - UndeadPeople Tileset [AftershockUDP],
    Blaze Industries - UndeadPeople Tileset [BlazeIndustriesUDP],
    C.R.I.T Expansion Mod - UndeadPeople Tileset [crt_expansionUDP],
    DinoMod - UndeadPeople Tileset [DinoModUDP],
    Graphical Overmap [Graphical_Overmap],
    Graphical Overmap Magiclysm [Graphical_Overmap_Magiclysm],
    Magiclysm - UndeadPeople Tileset [MagiclysmUDP],
    SpeedyDex [speedydex],
    Stats Through Kills [stats_through_kills],
    Stats Through Skills [StatsThroughSkills],
    Useful Helicopters [useful_helicopters]

Additional context

No response

@atealein
Copy link
Contributor

I can confirm this behavior, it seems as if they don't count the potential extra volume available in the containers as available when you trade with them.

@Entity-y
Copy link
Contributor

Can also confirm, have to debug swap characters to make use of the extra storage space.

@ProfoundDarkness
Copy link
Contributor

This looks a lot like #52088... The compile today (I'm on version 8256058) didn't seem to introduce new issues getting stuff into NPC inventories for me. I also swapped one of my NPC's storage around a lot today, including a new backpack and gear.

If you tell them to hold onto items instead of trying to use trade to give them stuff, and they actually have space available, it works. Even if it shows 0 available volume on trade. The linked issue has other ideas I had for getting stuff into NPC's inventory. If that 'hold onto this thing' didn't work, you might have something different going on.

To be more specific to what I think is going on, the issue is that for quite a while, since before I resumed playing experimentals around August, NPCs had 0 available volume in trade. Now either intentional or bug, trade ALSO didn't count the volume of things you were giving to them (if from your own storage). Meaning they had 0 volume to start on trade, you give them a bunch of stuff from your storage, they still have 0 volume, it's non-negative, so it works. With the bug fixes, trade now counts the volume of stuff you are giving them in trade but still doesn't calculate their storage capacity. Thus you have to get creative to get stuff in their inventory.

@wapcaplet wapcaplet added (S2 - Confirmed) Bug that's been confirmed to exist <Bug> This needs to be fixed Items: Containers Things that hold other things NPC / Factions NPCs, AI, Speech, Factions, Ownership labels Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Items: Containers Things that hold other things NPC / Factions NPCs, AI, Speech, Factions, Ownership (S2 - Confirmed) Bug that's been confirmed to exist
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants