Segmentation fault when trading with Eddie Isherwood from the Isherwood ranches.

[Quintovir]

Describe the bug

When I accept a trade with Eddie Isherwood the game crashes.

Steps To Reproduce

1. Select Eddie's "3L glass jar (sealed) > milk (fresh)" and "plastic bag > cheese".
2. Select my disposable batteries.
3. Press Enter.
4. Confirm the trade by pressing "Y".

Expected behavior

The game should not crash when trading with Eddie Isherwood.

Screenshots

No response

Versions and configuration

• OS: Linux
  • OS Version: LSB Version: n/a; Distributor ID: ManjaroLinux; Description: Manjaro Linux; Release: 21.1.3; Codename: Pahvo;
• Game Version: 0.F-3098-g15692c4b21-dirty [64-bit]
• Graphics Version: Tiles
• Game Language: System language []
• Mods loaded: [
  Dark Days Ahead [dda],
  Blaze Industries [blazeindustries],
  Fuji's Military Profession Pack [fuji_mpp],
  No Fungal Growth [no_fungal_growth],
  SpeedyDex [speedydex],
  Stats Through Kills [stats_through_kills],
  Stats Through Skills [StatsThroughSkills]
  ]

Additional context

Save game with crash.log.
TRADE SEGMENTATION FAULT.zip

[ferociousdork]

Seems to have been caused by #51704. ip is copied here instead of captured by reference:

Cataclysm-DDA/src/npctrade.cpp

Line 86 in 81ae267

for( item_pricing ip : sorted_stuff ) {

which causes the pointer here refer to local stack memory:

Cataclysm-DDA/src/npctrade.cpp

Line 140 in 81ae267

from_map.push_back( &ip.loc );

[zakhad]

I believe i might have been getting the same issue but with trading with hub 0

crash (1).log
debug.log