Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isherwood Farms location is not unique. #50800

Closed
freijie opened this issue Aug 15, 2021 · 3 comments
Closed

Isherwood Farms location is not unique. #50800

freijie opened this issue Aug 15, 2021 · 3 comments
Labels
<Bug> This needs to be fixed <Enhancement / Feature> New features, or enhancements on existing Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Map / Mapgen Overmap, Mapgen, Map extras, Map display (S3 - Duplicate) Bug that is duplicate of another one

Comments

@freijie
Copy link

freijie commented Aug 15, 2021

Describe the bug

Isherwood Farms location is generated more than once per world, with Isherwood family npcs getting duplicated.

Steps To Reproduce

Make a world, travel a lot.

Expected behavior

This location should be unique.

As a side note, it would be nice to improve outline of the map chunk to make it blend in the world properly:
Change forest type to match the rest of overmap (instead of "#" type, è type)
Remove some of the outer forest tiles to avoid making it look like a perfect square

Screenshots

No response

Versions and configuration

  • OS: W10
  • Game Version: c850e91
  • Graphics version: [Tiles or Terminal]
  • Ingame language: English
  • Mods loaded: magiclysm, some unrelated to mapgen mods.

Additional context

No response

@RenechCDDA
Copy link
Member

This is intentional to some degree, and there are some plans on how to 'fix' it. See also: #49322

tl;dr: It would be bad if you could lock yourself out from finding a special location by not correctly guessing the direction from your original spawn. Therefore, if you go really far you can find more than one.

@actual-nh
Copy link
Contributor

As a side note, it would be nice to improve outline of the map chunk to make it blend in the world properly:
Change forest type to match the rest of overmap (instead of "#" type, è type)
Remove some of the outer forest tiles to avoid making it look like a perfect square

If you could make this into a feature request?

@actual-nh actual-nh added (S3 - Duplicate) Bug that is duplicate of another one <Bug> This needs to be fixed <Enhancement / Feature> New features, or enhancements on existing Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Map / Mapgen Overmap, Mapgen, Map extras, Map display labels Aug 15, 2021
@freijie
Copy link
Author

freijie commented Aug 15, 2021

This is intentional to some degree, and there are some plans on how to 'fix' it. See also: #49322

tl;dr: It would be bad if you could lock yourself out from finding a special location by not correctly guessing the direction from your original spawn. Therefore, if you go really far you can find more than one.

In my current run I have 3 Isherwood farms already
on a dingle town with dist. between towns = 8

Good to know its a known issue, I'll make a feature request later.

@freijie freijie closed this as completed Aug 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed <Enhancement / Feature> New features, or enhancements on existing Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Map / Mapgen Overmap, Mapgen, Map extras, Map display (S3 - Duplicate) Bug that is duplicate of another one
Projects
None yet
Development

No branches or pull requests

3 participants