Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Items can be duplicated by exchanging with companions. #50454

Closed
sharkfinsouperman opened this issue Aug 3, 2021 · 2 comments · Fixed by #51704
Closed

Items can be duplicated by exchanging with companions. #50454

sharkfinsouperman opened this issue Aug 3, 2021 · 2 comments · Fixed by #51704
Labels
<Bug> This needs to be fixed <Exploit> Unintended interactions or behavior, usually breaking how the game is balanced NPC / Factions NPCs, AI, Speech, Factions, Ownership

Comments

@sharkfinsouperman
Copy link

Describe the bug

Any item may be duplicated if it can fit into a companion's inventory.

Steps To Reproduce

  1. Equip a companion with clothing with pockets and a pack.
  2. Give them items to hold.
  3. Open the trade screen and select both the item or items to be duplicated and the clothing items that contain those same items and complete the exchange.
  4. You're survivor will now have the container with the item inside and an duplicate item.

Expected behavior

I would expect the marked item would be unmarked when the container is also marked for trade because one item cannot be traded in two separate instances.

Screenshots

No response

Versions and configuration

  • Win7
  • Frank (0.F Stable)

Additional context

No response
@BrettDong BrettDong added <Bug> This needs to be fixed <Exploit> Unintended interactions or behavior, usually breaking how the game is balanced NPC / Factions NPCs, AI, Speech, Factions, Ownership labels Aug 3, 2021
@GoLoT
Copy link
Contributor

GoLoT commented Aug 3, 2021

Duplicate of #46874

@RoyBerube
Copy link
Contributor

I expect a solution can be similar to PR #46486

@RoyBerube RoyBerube mentioned this issue Sep 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
<Bug> This needs to be fixed <Exploit> Unintended interactions or behavior, usually breaking how the game is balanced NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

NPC trade - bugfixes and improvements RoyBerube/Cataclysm-DDA
4 participants
@GoLoT @BrettDong @RoyBerube @sharkfinsouperman