Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shivering Mechanics #47671

Closed
morthein opened this issue Feb 22, 2021 · 5 comments
Closed

Shivering Mechanics #47671

morthein opened this issue Feb 22, 2021 · 5 comments
Labels
<Bug> This needs to be fixed Mechanics: Character / Player Character / Player mechanics

Comments

@morthein
Copy link

Is your feature request related to a problem? Please describe.

Currently, if you're cold and attempt to go to bed, you will not fall asleep due to shivering even though you may have a blanket on the same place you're attempting to sleep in.

Describe the solution you'd like

It would be divine if the game could assume you are "wearing" the blanket for the warmth bonuses in the case of sleeping. Otherwise, you have to actually wear the blanket, just to go to sleep. (Note: The blanket DOES apply it's warmth while your asleep, "You use your blanket to keep warm" so I wonder why can't it apply that while attempting to sleep.

Describe alternatives you've considered

The blanket could simply add warmth to your body for being on the same space as it and attempting to sleep. I suppose it could add warmth to you even when spending time there and not sleeping. Or maybe apply the "you use your blanket to keep warm" effect could just apply while in the same place as a blanket.

Additional context

It's not like wearing the blanket and then taking it off is the worst thing in the world, but attempting to sleep then shivering awake, then having to wear the blanket your sleeping with, then sleep, then wake up and take off the blanket, then drop it, is just repetitive.

@souricelle
Copy link
Contributor

Can confirm, this basically makes innawoods starts impossible as there's no way to get a blanket early and the game won't let you sleep even in an improvised shelter with a fire going at midday.

@NetSysFire
Copy link
Member

This also bypasses "Survivor sleep now" and "You collapse due to lack of sleep", allowing insane sleep deprivation to be possible.

@stale
Copy link

stale bot commented Apr 27, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@stale stale bot added the stale Closed for lack of activity, but still valid. label Apr 27, 2022
@Fris0uman
Copy link
Contributor

Fris0uman commented Oct 15, 2022

So actually You use your blanket to keep warm does not do anything
Code starts here:

std::string item_name = is_snuggling();

  std::string item_name = is_snuggling();
    if( item_name == "many" ) {
        if( one_in( 15 ) ) {
            add_msg_if_player( _( "You nestle into your pile of clothes for warmth." ) );
        } else {
            add_msg_if_player( _( "You use your pile of clothes for warmth." ) );
        }
    } else if( item_name != "nothing" ) {
        if( one_in( 15 ) ) {
            add_msg_if_player( _( "You snuggle your %s to keep warm." ), item_name );
        } else {
            add_msg_if_player( _( "You use your %s to keep warm." ), item_name );
        }
    }

and is_snuggling() just get the name of the item or items that could be used to keep warm, but as far as I can tell no warmth bonus is awarded there. Unless I'm missing something we're missing a piece of code so that the sleeping on blanket or cloth shoud give some warmth. OR the message should be removed becasue it's lying.

@stale stale bot removed the stale Closed for lack of activity, but still valid. label Oct 15, 2022
@Fris0uman Fris0uman added the <Bug> This needs to be fixed label Oct 15, 2022
@Night-Pryanik
Copy link
Contributor

Can't confirm on latest experimental as of 15 November 2024.

Made my character feel very cold!
изображение

Made my character try to fall asleep, he used the blanket lying on the floor to get warm
изображение

@Night-Pryanik Night-Pryanik closed this as not planned Won't fix, can't repro, duplicate, stale Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Mechanics: Character / Player Character / Player mechanics
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants