Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The JSON formatter output contains lines that are longer than 120 characters #46412

Closed
int-ua opened this issue Dec 30, 2020 · 1 comment
Closed

The JSON formatter output contains lines that are longer than 120 characters #46412

int-ua opened this issue Dec 30, 2020 · 1 comment
Labels
<Bug> This needs to be fixed [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style Code: Tooling Tooling that is not part of the main game but is part of the repo. [JSON] Changes (can be) made in JSON (S3 - Duplicate) Bug that is duplicate of another one

Comments

@int-ua
Copy link
Contributor

int-ua commented Dec 30, 2020 •
edited
Loading

Describe the bug

Cataclysm-DDA/gfx/UltimateCataclysm/tile_config.json

Line 6006 in 8bced72

"id": [ "golf_ball", "bowling_ball", "baseball", "football", "basketball", "indoor_volleyball", "beach_volleyball", "puck" ],

The longest line is 137 characters long

           "//": [ "hdframe_horizontal_unconnected_rotW", "hdframe_horizontal_unconnected_rotS", "hdframe_horizontal_unconnected_rotE" ],

Steps To Reproduce

$ grep -x '.\{121,\}' gfx/UltimateCataclysm/tile_config.json | wc -l
42

Or feed the current gfx/UltimateCataclysm/tile_config.json to the https://dev.narc.ro/cataclysm/format.html

Expected behavior

All lines are shorter than 120 characters.

Versions and configuration

master code

Additional context

Tried implementing a linter with the same style in Python, found this difference.
@int-ua int-ua added <Bug> This needs to be fixed [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style Code: Tooling Tooling that is not part of the main game but is part of the repo. labels Dec 30, 2020
@kevingranade
Copy link
Member

See also #38007

@int-ua int-ua added the (S3 - Duplicate) Bug that is duplicate of another one label Jan 5, 2021
@int-ua int-ua closed this as completed Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
<Bug> This needs to be fixed [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style Code: Tooling Tooling that is not part of the main game but is part of the repo. [JSON] Changes (can be) made in JSON (S3 - Duplicate) Bug that is duplicate of another one
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kevingranade @int-ua