Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyper-metabolism does nothing #45329

Closed
seerdecker opened this issue Nov 10, 2020 · 1 comment · Fixed by #45687
Closed

Hyper-metabolism does nothing #45329

seerdecker opened this issue Nov 10, 2020 · 1 comment · Fixed by #45687
Labels
<Bug> This needs to be fixed Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies (S2 - Confirmed) Bug that's been confirmed to exist

Comments

@seerdecker
Copy link

Game version: b11142.

Got hyper-metabolism on. Eating never triggers the "You feel the %s filling you out." message unless I debug-edit the hunger level. Stomach bursts due to overeating if I do not use the debug menu.

@anothersimulacrum anothersimulacrum added the Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies label Nov 10, 2020
@wapcaplet
Copy link
Contributor

wapcaplet commented Nov 11, 2020

Confirmed in 0.E-7424-gcbcf5fd9, by acquiring the "Chaos" and "Hyper-Metabolism" traits, then getting hungry and eating lots of food. Never once was "You feel the ... filling you out" shown.

The section that checks for this trait appears to be unreachable, since get_hunger() returns positive values (or 0), while capacity = stomach_capacity() returns negative values (or 0). So if( get_hunger() < capacity ) would always be false:

if( get_hunger() < capacity && has_trait( trait_EATHEALTH ) ) {
int excess_food = capacity - get_hunger();
add_msg_player_or_npc( _( "You feel the %s filling you out." ),

Edit I see that it's possible for get_hunger() to be negative when you are full / engorged, but it appears to be getting reset to 0 sometime before the above condition is reached.

@wapcaplet wapcaplet added (S2 - Confirmed) Bug that's been confirmed to exist <Bug> This needs to be fixed labels Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies (S2 - Confirmed) Bug that's been confirmed to exist
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants