Gathering water into wielded container do not change weight

[starytroll]

Describe the bug

It seems that pouring water from a pool to wielded tank does not change weight of carried item, so that I can travel with it without additional pain/stamina cost.

Steps To Reproduce

1. Wield metal tank.
2. 'e'xamine water tile and put the water into tank.
3. Check 'i'nventory and see that total weight remains unchanged.

Expected behavior

The carried mass should change after filling the container.

Screenshots

Versions and configuration

• OS: Windows
  • OS Version: MINGW/CYGWIN/MSYS2 on unknown Windows version
• Game Version: 0.E-5457-gaeb89fd [64-bit]
• Graphics Version: Tiles
• Game Language: English [en]
• Mods loaded: [
  Dark Days Ahead [dda],
  Disable NPC Needs [no_npc_food],
  Alternative Map Key [alt_map_key]
  ]

Additional context

Probably it is the case for other containers as well.

[mqrause]

Seems like an issue with the weight cache not always being up to date. With a bunch of tries, I can pick up a filled 60l tank without adding any weight to my inventory. The issue solves itself after a while, though.

[wapcaplet]

I can reproduce this issue in 0.E-5679-g446c750473.

Starting with the 4.0 kg of clothes I'm wearing:

Picking up and wielding an empty 60L tank (5.67 kg), my weight is up to 9.7 kg:

Going down to the river and filling up the 60L tank completely, I see my weight has not changed, even if I walk around for a bit afterwards:

Looking at the tank, it shows its own weight correctly as 65.67 kg:

If I drop the tank, then pick it up (and wield it) again, it becomes weightless, and I am back to my original 4.0 kg:

However, if I get another empty 60L tank, and fill it up from the toilets in the evac shelter basement:

It is not enough units to completely fill the tank, and I see the weight correctly updates in my inventory:

Dropping and picking up this partly full (partly empty) tank, my inventory weight is correctly updated.

So it seems this only affects full tanks for some reason.

[RoyBerube]

Some testing I've done indicates that if you have enough space to put the item in inventory, then the weight is calculated correctly. It does not apply just to fluid tanks.

For example with a hiking backpack that cannot be held in inventory, wearing it adds no weight. Adding items to it can trigger the weight to be displayed properly but not always. With a car battery and hammer contained and wearing it from the floor, it adds no weight. Unloading the backpack then shows the correct weight.