Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Biosilicified) chitin armor doesn't actually protect from acid #43117

Closed
DeltaEpsilon7787 opened this issue Aug 22, 2020 · 2 comments · Fixed by #43144
Closed

(Biosilicified) chitin armor doesn't actually protect from acid #43117

DeltaEpsilon7787 opened this issue Aug 22, 2020 · 2 comments · Fixed by #43144
Labels
<Bug> This needs to be fixed [C++] Changes (can be) made in C++. Previously named `Code`

Comments

@DeltaEpsilon7787
Copy link
Contributor

Describe the bug

The description of the biosilicified armor states it's acid-resistant, but actual acid protection value stated is 0.

Steps To Reproduce

  1. Debug menu -> learn all recipes
  2. Crafting menu -> biosilicified armor
  3. Check the screenshot

Expected behavior

Description matches reality.

Screenshots

image

Versions and configuration

  • OS: Windows
    • OS Version: 10.0 1909
  • Game Version: 0.E-5241-g89c6d05 [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food]
    ]

Additional context

Other equipment does actually have acid protection.
@anothersimulacrum anothersimulacrum added [JSON] Changes (can be) made in JSON Good First Issue This is a good first issue for a new contributor labels Aug 22, 2020
@MrWoot MrWoot mentioned this issue Aug 22, 2020
Merged
@MrWoot
Copy link
Contributor

MrWoot commented Aug 22, 2020

Submitted pull request.

@anothersimulacrum anothersimulacrum mentioned this issue Aug 23, 2020
Merged
@stale
Copy link

stale bot commented Sep 27, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@stale stale bot added the stale Closed for lack of activity, but still valid. label Sep 27, 2020
@anothersimulacrum anothersimulacrum added <Bug> This needs to be fixed [C++] Changes (can be) made in C++. Previously named `Code` and removed Good First Issue This is a good first issue for a new contributor [JSON] Changes (can be) made in JSON labels Sep 27, 2020
@stale stale bot removed stale Closed for lack of activity, but still valid. labels Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
<Bug> This needs to be fixed [C++] Changes (can be) made in C++. Previously named `Code`
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expand generic factory to include relative and proportional support. anothersimulacrum/Cataclysm-DDA
4 participants
@kevingranade @DeltaEpsilon7787 @MrWoot @anothersimulacrum