Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trading with NPC's does not update their volume indicator #42432

Closed
Survivor1998 opened this issue Jul 24, 2020 · 2 comments · Fixed by #51704
Closed

Trading with NPC's does not update their volume indicator #42432

Survivor1998 opened this issue Jul 24, 2020 · 2 comments · Fixed by #51704
Labels
<Bug> This needs to be fixed Controls / Input Keyboard, mouse, keybindings, input UI, etc. Info / User Interface Game - player communication, menus, etc. NPC / Factions NPCs, AI, Speech, Factions, Ownership

Comments

@Survivor1998
Copy link

Describe the bug

When trading with an NPC, after taking all their items, the volume indicator was still at 0.

Steps To Reproduce

  1. Convince the starter NPC on the sheltered scenario to travel with you
  2. Ask this NPC to trade with you
  3. Take all of their items through trading
  4. Notice that their volume indicator is still at 0.

Expected behavior

I expected to remove items from the NPC, and then give other items back after the available volume was updated. The item I attempted to give in the example below was a pair of boxer shorts.

Screenshots

In this screenshot I took all the NPC's stuff
image

In the second screenshot I attempted to give back some shorts, which doesn't work
image

Versions and configuration

  • OS: Windows 10.0 1903
  • Game Version: 0.E-4395-g83ce24e [64-bit]
  • Graphics version: Tiles
  • Ingame language: English
  • Mods loaded: dda, disable npc needs, StatsThroughSkills]

Additional context

I hope this was helpful, this is my first ever bug report and English is not my first language.

@GGgatherer
Copy link
Contributor

Interesting. Looks like NPCs cannot recognize when they should wear given items instead of trying to stash them into already-worn items. Which, of course, they do not have in this case.
Did you try giving the shorts via 'use this item' dialogue option? Or maybe 'hold on to this item'?

@anothersimulacrum anothersimulacrum added <Bug> This needs to be fixed Controls / Input Keyboard, mouse, keybindings, input UI, etc. Info / User Interface Game - player communication, menus, etc. NPC / Factions NPCs, AI, Speech, Factions, Ownership labels Jul 29, 2020
@ZhilkinSerg ZhilkinSerg added Info / User Interface Game - player communication, menus, etc. and removed Info / User Interface Game - player communication, menus, etc. labels Aug 19, 2020
@hexagonrecursion
Copy link
Contributor

hexagonrecursion commented Aug 23, 2021

When you start trading with an NPC the volume always starts at zero even if she is wearing a container eg a duffel bag. This affects both neutral NPCs and followers. Does not affect the refugee center merchant (volume precisely 5000L).

Possibly related: #40175

Workaround for equipping followers:

  • Use "I want you to use this item" to make sure he is wearing a backpack
  • Use "Hold onto this item" to give items to the NPC
  • OS: Linux
    • OS Version: LSB Version: :core-4.1-amd64:core-4.1-noarch; Distributor ID: Fedora; Description: Fedora release 33 (Thirty Three); Release: 33; Codename: ThirtyThree;
  • Game Version: 8051d7d [64-bit]
  • Graphics Version: Tiles
  • Game Language: English [en]
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Bionic Professions [package_bionic_professions]
    ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Controls / Input Keyboard, mouse, keybindings, input UI, etc. Info / User Interface Game - player communication, menus, etc. NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants