Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting opened aluminum or tin cans (i.e. crafting oil lamp) #41298

Closed
GreatLurdo opened this issue Jun 14, 2020 · 2 comments · Fixed by #41332
Closed

Getting opened aluminum or tin cans (i.e. crafting oil lamp) #41298

GreatLurdo opened this issue Jun 14, 2020 · 2 comments · Fixed by #41332
Labels
<Bug> This needs to be fixed Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Good First Issue This is a good first issue for a new contributor [JSON] Changes (can be) made in JSON

Comments

@GreatLurdo
Copy link

GreatLurdo commented Jun 14, 2020

Describe the bug

To craft an oil lamp, opened aluminum or tin cans can be used as components. However, when the food inside one of these cans is consumed, the by-product is not "opened". The only way to get them is finding them already opened.

Steps To Reproduce

  1. Get an aluminum can of root beer.
  2. Drink the content.
  3. An "aluminum can" is left in the inventory (not an "opened aluminum can").

Expected behavior

To craft certain items, like an oil lamp, an "opened" can is needed. So either the by-product of consuming a can should be "opened" or the recipe ingredient changed.

Screenshots

Versions and configuration

  • OS: Windows
    • OS Version: 10.0 1903
  • Game Version: 0.E-3159-g3f48507 [64-bit]
  • Graphics Version: Tiles
  • Game Language: English [en]
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Stats Through Skills [StatsThroughSkills]
    ]

Additional context

@wapcaplet
Copy link
Contributor

The general problems with cans have been known for a while (#40127, #40658, #40742), but your issue report looks like the first clear description of this particular facet of it - that their state is not correctly changed from "closed" to "opened". This issue is not a duplicate of those issues, since the symptom and use cases are different, but the root cause(s) are likely to be related.

@anothersimulacrum anothersimulacrum added <Bug> This needs to be fixed [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Good First Issue This is a good first issue for a new contributor labels Jun 15, 2020
@anothersimulacrum
Copy link
Member

To my knowledge, the opened variants of those cans are deprecated, and the pockets of the sealed versions are supposed to transition between sealed and unsealed.
As such, to fix this, you'd just need to change the cans used in those recipes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Good First Issue This is a good first issue for a new contributor [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants