Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quiver item info display shows no storage and does not show that it can store arrows #40521

Closed
Nadario opened this issue May 13, 2020 · 3 comments · Fixed by #41532
Closed

Quiver item info display shows no storage and does not show that it can store arrows #40521

Nadario opened this issue May 13, 2020 · 3 comments · Fixed by #41532
Labels
<Bug> This needs to be fixed Info / User Interface Game - player communication, menus, etc. Items: Containers Things that hold other things

Comments

@Nadario
Copy link

Nadario commented May 13, 2020

Describe the bug

Quivers have one pocket with 0.00 storage max size and weight.
They also cannot be activated to store arrows.
When looking at arrows it says "can be stored in: bow sling, back holster, hiking backpack, and golf bag" with no mention of quivers.

Steps To Reproduce

Craft a quiver and try to store arrows.

Expected behavior

You will be unable to store the arrows.

Screenshots

quiver
arrow

Versions and configuration

  • OS: Windows 10
  • Game Version: 0.E-2125-g7d04bfa
  • Graphics version: Tiles
  • Ingame language: English
  • Mods loaded:
    -->Dark Days Ahead
    -Disable NPCs Needs
    -SpeedyDex
    -Stats Through Skills
    -sees-player icon, retrodays
    -Fuji's Military Proffesion Pack
    -MSX Indicator: REMIX
    -Zetsukaze's Hair - O.E EDIT
@KorGgenT
Copy link
Member

you don't activate them - you either put things in them automatically with the best pocket algorithm or you can insert. the 0.0 storage is a display thing that i probably need to remove as this has been reported as a bug multiple times now.

@KorGgenT KorGgenT added Info / User Interface Game - player communication, menus, etc. <Bug> This needs to be fixed Items: Containers Things that hold other things labels May 13, 2020
@KorGgenT KorGgenT changed the title Quivers have no storage and cannot be activated. Quiver item info display shows no storage and does not show that it can store arrows May 13, 2020
@Nadario
Copy link
Author

Nadario commented May 13, 2020

you don't activate them - you either put things in them automatically with the best pocket algorithm or you can insert. the 0.0 storage is a display thing that i probably need to remove as this has been reported as a bug multiple times now.

I tried to use insert while having the arrows in the inventory and I could not put them in the quiver, same when they are on the ground. It worked with best pocket when I tried to pick up just 20, but not when i I tried with 100.
Also the description of the quiver should be changed as it says "Activate to store arrows.".

@wapcaplet
Copy link
Contributor

I have an idea of how to fix this - I think it affects any item using ammo_restriction to define what it can hold, since the size of that ammo will determine the container's total capacity.

However, it only works when the pocket type is MAGAZINE. The quivers have ammo_restriction but are not MAGAZINE type. I'll try patching this in the JSON data and open a PR if it works out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Info / User Interface Game - player communication, menus, etc. Items: Containers Things that hold other things
Projects
None yet
3 participants