Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize unicode characters #40205

Open
ymber opened this issue May 5, 2020 · 2 comments
Open

Standardize unicode characters #40205

ymber opened this issue May 5, 2020 · 2 comments
Labels
[C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON (P4 - Low) Low priority issues: things which are e.g exotic, minor and/or hard to encounter

Comments

@ymber
Copy link
Member

ymber commented May 5, 2020

Is your feature request related to a problem? Please describe.

Unicode characters are literal characters or escape sequences in different places.

Describe the solution you'd like

Pick one and make everything in the repo use it. CI should enforce it.
@ymber ymber added [JSON] Changes (can be) made in JSON [C++] Changes (can be) made in C++. Previously named `Code` (P4 - Low) Low priority issues: things which are e.g exotic, minor and/or hard to encounter labels May 5, 2020
@ZhilkinSerg
Copy link
Contributor

Escape sequences seems to be the proper way, but using them in mapgen palettes would not bring any good.

@jbytheway
Copy link
Contributor

I'd lean towards literal characters as the better default, except in cases of visual ambiguity (such as non-breaking spaces, of which we have a few).

This was referenced May 10, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON (P4 - Low) Low priority issues: things which are e.g exotic, minor and/or hard to encounter
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jbytheway @ZhilkinSerg @ymber