Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plastic canteen holding my two-way radio? #40174

Closed
Resok opened this issue May 5, 2020 · 4 comments
Closed

Plastic canteen holding my two-way radio? #40174

Resok opened this issue May 5, 2020 · 4 comments
Labels
<Enhancement / Feature> New features, or enhancements on existing Items: Containers Things that hold other things (S3 - Duplicate) Bug that is duplicate of another one

Comments

@Resok
Copy link
Contributor

Resok commented May 5, 2020

Describe the bug

Plastic canteen holding my two-way radio?

Steps To Reproduce

  1. Pickup and wear a plastic canteen (or any similar item that can fit a similarly implausible item within it).
  2. Pickup a two-way radio

Expected behavior

Two-way radio should not be able to fit inside a plastic canteen.

Screenshots

image

image

Versions and configuration

  • OS: Windows
    • OS Version: 10.0 1909
  • Game Version: 0.E-1758-g7161a41 [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [
    Dark Days Ahead [dda],
    Magiclysm [magiclysm],
    Stats Through Skills [StatsThroughSkills],
    Mutant Animals [mutant_animals],
    Mutant Insects [mutant_insects],
    Classes and Scenarios Mod [more_classes_scenarios],
    Sleep Deprivation [sleepdeprivation]
    ]
@RoyBerube
Copy link
Contributor

There are two issues here: the first is that it is not possible yet to prioritize where picked up loot is placed, and the other is about items and containers not yet having dimensional restrictions other than total volume.

The first problem should be somewhat easy to implement.

The second with the dimension requirements would be a lot more work as every item and container in the game would need the dimension data added. Not to mention the code. I've seen some discussion about this but would be a big undertaking to do properly.

@Resok
Copy link
Contributor Author

Resok commented May 5, 2020

In theory it looks like this should fix this -

#40186

@KorGgenT
Copy link
Member

KorGgenT commented May 5, 2020

possibly, but it could be a different pr that fixes this. there are 2 separate features i'm adding to pockets: max length, and max size.

@KorGgenT KorGgenT added <Enhancement / Feature> New features, or enhancements on existing Items: Containers Things that hold other things labels May 5, 2020
@KorGgenT
Copy link
Member

KorGgenT commented May 5, 2020

duplicate of #40130

@KorGgenT KorGgenT added the (S3 - Duplicate) Bug that is duplicate of another one label May 5, 2020
@KorGgenT KorGgenT closed this as completed May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Enhancement / Feature> New features, or enhancements on existing Items: Containers Things that hold other things (S3 - Duplicate) Bug that is duplicate of another one
Projects
None yet
Development

No branches or pull requests

3 participants