Liquid issues with #39406

[RedShakespeare]

Describe the bug

1. When trying to drink liquid with "[a]pply or use item", all liquid in container will leak onto the ground including the unit just drunk by the player.
2. One can [d]rop liquid item directly without unpacking the container, which gives access to empty but sealed tin cans or other things.
3. Same kind of containers will appear in one line in [e]xamine or "picking up"[g] lists, no matter whether they contain items or not.

Steps To Reproduce

Problem 1:

1. Make a player with a gallon jug of cheap wine.
2. Use [a]pply list to drink a unit of wine.
3. You will find the gallon jug empty and all wine on the ground dirty.

Problem 2:

1. Make a player with a medium tin can of broth.
2. Use [d]rop or [D]rop list to directly drop the broth instead of the can.
3. The broth is dropped onto the ground but the can remains sealed.

Problem 3:

1. Make a player with a plastic bottle of water and an empty plastic bottle.
2. Drop both bottles onto the ground.
3. [e]xamine the bottles.
4. You will find only one line named either "plastic bottles" or "plastic bottles with water", determined by the order of dropping.

Expected behavior

... just what it should be

Versions and configuration

• Game Version: 0.E-1713-gd15c896

Additional words

Just need some adjustment about #39406

[BenlyAZ]

I also found myself unable to drink water from a jar using the (E)at command, as the game considered it spilled liquid. (Selecting the water in inventory and then choosing eat from the action menu worked, though.)

[RedShakespeare]

I also found myself unable to drink water from a jar using the (E)at command, as the game considered it spilled liquid

This problem may have been fixed in #40108 before I raised this issue so I didn't mention it here ... but yes, that's a related problem too. Thx for supplementary.

[Rivet-the-Zombie]

Liquids seem all kinds of wonky right now.

[RedShakespeare]

Yes...

Update:
Problem 1 can only be triggered by some very types of liquid like water, cheap wine and ammonia, but not liquid like clean water or broth.
And...if the former kinds of liquid is spawned with containers ( either by debug menu or by spells ), when [a]pply-ing a debugmsg will occur.

Looks like it is because the spawned items haven't got a location yet when the player tries to consume them. May also be related to item::in_its_container() in item.cpp

[DillonSimeone]

1. When trying to drink liquid with "[a]pply or use item", all liquid in container will leak onto the ground including the unit just drunk by the player.

This is no longer occurring on build 10689.

Spawned in a gallon jug of cheap wine...

Selected cheap wine...

Press active...

Move to the east...

No liquid spillage, and oddly, it makes my character tipsy despite not using up any wine. Could it be that exactly 1ml of the wine is getting used up on each active?

Spamming active on cheap wine...

No change to liters or weight.

[DillonSimeone]

2. One can [d]rop liquid item directly without unpacking the container, which gives access to empty but sealed tin cans or other things.

This is still happening on build 10689.

Can confirm that you can drop stuff out of sealed cans/jars without unsealing them. Look at the message log on the right, notice that I dropped the jam, and that the jam can in my inventory is still sealed despite being empty.

[KorGgenT]

that should be opened as a different issue.