Construction menu ambiguity between "Floor" and "Roof" #39972
Labels
Crafting / Construction / Recipes
Includes: Uncrafting / Disassembling
Fields / Furniture / Terrain / Traps
Objects that are part of the map or its features.
Good First Issue
This is a good first issue for a new contributor
stale
Closed for lack of activity, but still valid.
The nomenclature used for floor and roof constructions does not adequately inform the player of their behavior.
Both "Roof" and "Floor" constructions actually create floor terrain; "Roof" constructions are floors with the INDOORS flag, and "Floor" constructions are floors without the flag. In some cases, there is virtually no way of obviously intuiting this distinction in game.
Describe the solution you'd like
Names and descriptions for the floor/roof construction recipes and their corresponding terrain tiles should be reconciled for clarity. Roofed and Unroofed variants using the same materials should be brought in alignment.
"Roof" should only be used as the name for recipes that create roofs as seen from the current z-level. For example, the shingle roofs or flat roofs you can see when climbing buildings are "true" roofs, but a wooden floor with the INDOORS tag is not a roof.
Describe alternatives you've considered
I'm not sure there's any alternatives to this one. It's just a point where the construction recipes and in game terrains are not in total alignment and it creates confusion.
Additional context
Here is an example change to the two wooden floor recipes.
Build Wooden Floor
Construction ID: "constr_floor_noroof"
Post terrain ID: "t_floor_noroof"
Terrain Name:** "wooden floor"
Terrain Description: "Wooden floor created from boards, packed tightly together and nailed down.
Common in patios."Flags: [ "TRANSPARENT", "FLAMMABLE_HARD", "FLAT", "ROAD" ]
Build RoofBuild Wooden Floor (with roof)Construction ID:
"constr_floor""constr_floor_roofed"Post terrain ID:
"t_floor""t_floor_roofed"Terrain Name:
"floor""roofed wooden floor"Terrain Description: "
Interlocking wooden tiles that are more than likely treated against fire, with wooden posts and beams supporting a roof.Wooden floor created from boards, packed tightly together and nailed down. Integrated wooden posts and beams support the roof above."Flags: ["TRANSPARENT", "FLAMMABLE_HARD", "FLAT", "ROAD", "SUPPORTS_ROOF", "COLLAPSES", "INDOORS"]
I have never directly contributed to a Git project before, but if there is no current existing effort on this issue, I would be willing to go through the existing construction recipes and put together a revision that addresses this issue.
The text was updated successfully, but these errors were encountered: