Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Construction menu ambiguity between "Floor" and "Roof" #39972

Closed
SgtMustang opened this issue Apr 27, 2020 · 3 comments
Closed

Construction menu ambiguity between "Floor" and "Roof" #39972

SgtMustang opened this issue Apr 27, 2020 · 3 comments
Labels
Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Good First Issue This is a good first issue for a new contributor stale Closed for lack of activity, but still valid.

Comments

@SgtMustang
Copy link

SgtMustang commented Apr 27, 2020

The nomenclature used for floor and roof constructions does not adequately inform the player of their behavior.

Both "Roof" and "Floor" constructions actually create floor terrain; "Roof" constructions are floors with the INDOORS flag, and "Floor" constructions are floors without the flag. In some cases, there is virtually no way of obviously intuiting this distinction in game.

Describe the solution you'd like

Names and descriptions for the floor/roof construction recipes and their corresponding terrain tiles should be reconciled for clarity. Roofed and Unroofed variants using the same materials should be brought in alignment.

"Roof" should only be used as the name for recipes that create roofs as seen from the current z-level. For example, the shingle roofs or flat roofs you can see when climbing buildings are "true" roofs, but a wooden floor with the INDOORS tag is not a roof.

Describe alternatives you've considered

I'm not sure there's any alternatives to this one. It's just a point where the construction recipes and in game terrains are not in total alignment and it creates confusion.

Additional context

Here is an example change to the two wooden floor recipes.

Build Wooden Floor

Construction ID: "constr_floor_noroof"

Post terrain ID: "t_floor_noroof"

Terrain Name:** "wooden floor"

Terrain Description: "Wooden floor created from boards, packed tightly together and nailed down. Common in patios."

Flags: [ "TRANSPARENT", "FLAMMABLE_HARD", "FLAT", "ROAD" ]

Build Roof Build Wooden Floor (with roof)

Construction ID: "constr_floor" "constr_floor_roofed"

Post terrain ID: "t_floor" "t_floor_roofed"

Terrain Name: "floor" "roofed wooden floor"

Terrain Description: "Interlocking wooden tiles that are more than likely treated against fire, with wooden posts and beams supporting a roof. Wooden floor created from boards, packed tightly together and nailed down. Integrated wooden posts and beams support the roof above."

Flags: ["TRANSPARENT", "FLAMMABLE_HARD", "FLAT", "ROAD", "SUPPORTS_ROOF", "COLLAPSES", "INDOORS"]

I have never directly contributed to a Git project before, but if there is no current existing effort on this issue, I would be willing to go through the existing construction recipes and put together a revision that addresses this issue.

@SgtMustang SgtMustang changed the title Resolving Construction menu ambiguity between "Floors" and "Roofs" Construction menu ambiguity between "Floors" and "Roofs" Apr 27, 2020
@SgtMustang SgtMustang changed the title Construction menu ambiguity between "Floors" and "Roofs" Construction menu ambiguity between "Floor" and "Roof" Apr 27, 2020
@Night-Pryanik Night-Pryanik added Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Good First Issue This is a good first issue for a new contributor labels May 15, 2020
@Night-Pryanik
Copy link
Contributor

I would be willing to go through the existing construction recipes and put together a revision that addresses this issue.

Please do.

@stale
Copy link

stale bot commented Jun 14, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@stale stale bot added the stale Closed for lack of activity, but still valid. label Jun 14, 2020
@stale
Copy link

stale bot commented Jul 14, 2020

This issue has been automatically closed due to lack of activity. This does not mean that we do not value the issue. Feel free to request that it be re-opened if you are going to actively work on it

@stale stale bot closed this as completed Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Good First Issue This is a good first issue for a new contributor stale Closed for lack of activity, but still valid.
Projects
None yet
Development

No branches or pull requests

2 participants