Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Science ID only refrences the M240 turret, but not the M2HB turret to be disabled on entrances #38717

Closed
GhostEcho opened this issue Mar 12, 2020 · 3 comments · Fixed by #38725
Labels
<Bug> This needs to be fixed [C++] Changes (can be) made in C++. Previously named `Code` Good First Issue This is a good first issue for a new contributor Spawn Creatures, items, vehicles, locations appearing on map

Comments

@GhostEcho
Copy link

GhostEcho commented Mar 12, 2020

Describe the bug

If you look at the Science ID reader code, it only references the ID "mon_turret_rifle", which is the M249 turret in lab entrances, but the M2HB can also spawn there, which is "mon_turret_bmg". This means the M2HB does not get triggered to disappear like the M249 does leaving people a nasty .50cal surprise.

Steps To Reproduce

  1. Generate a lab with a M2HB turret guarding the enterance
  2. Swipe ID in front of the doors
  3. Get head turned into red mist

Solution

( critter.type->id == mon_turret_rifle ) &&

This needs to be adjusted to include the M2HB, but should also make sure that any other spawnable turrets also get included

@KorGgenT KorGgenT added [C++] Changes (can be) made in C++. Previously named `Code` Good First Issue This is a good first issue for a new contributor Spawn Creatures, items, vehicles, locations appearing on map <Bug> This needs to be fixed labels Mar 12, 2020
@Amoebka
Copy link
Contributor

Amoebka commented Mar 12, 2020

Reported before in #36415 and supposedly fixed by #36462.
You are probably playing an old experimental or stable.

@GhostEcho
Copy link
Author

@Amoebka it was in 10412 while watching Vormithrax's stream tonight, KorGen was there was well and we were talking about it

@anothersimulacrum
Copy link
Member

The change in #36462 was to remove_submap_turrets, which is a function local to computer.cpp and not used in iexamine.cpp, where the card reader turret removal occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed [C++] Changes (can be) made in C++. Previously named `Code` Good First Issue This is a good first issue for a new contributor Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
4 participants