Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow in-game customization of map extra auto-note styles #38648

Closed
natsirt721 opened this issue Mar 8, 2020 · 9 comments
Closed

Allow in-game customization of map extra auto-note styles #38648

natsirt721 opened this issue Mar 8, 2020 · 9 comments
Labels
Info / User Interface Game - player communication, menus, etc. Map / Mapgen Overmap, Mapgen, Map extras, Map display stale Closed for lack of activity, but still valid. <Suggestion / Discussion> Talk it out before implementing

Comments

@natsirt721
Copy link
Contributor

Is your feature request related to a problem? Please describe.

With the 'auto map extra notes' option enabled, the character/color combination is always a yellow 'x'. When many categories are enabled, this makes it hard to tell at a glance from the map which 'x's correspond to which extras.

Describe the solution you'd like

Add an option in the Auto Notes Manager to set the character and color of each map extra on the overmap. Possibly let the entire note message be customized. These settings should persist between saves, even though they may not appear in the menu due to not having been discovered by that character yet.

Describe alternatives you've considered

Mainline a unique set of characters and colors in map_extras.json rather than let the user customize them, but as the json entries for character and color already exist this seems like a halfway solution.

@Night-Pryanik Night-Pryanik added <Suggestion / Discussion> Talk it out before implementing Info / User Interface Game - player communication, menus, etc. Map / Mapgen Overmap, Mapgen, Map extras, Map display labels Mar 8, 2020
@jkraybill
Copy link
Contributor

I would love if extras used different marks on the map, and FWIW I would be totally fine with not being able to customize them in-game (that feature seems like a lot more work than just using different markings).

@Amoebka
Copy link
Contributor

Amoebka commented Mar 9, 2020

As mentioned, you can already customize marks and colors by editing map_extras.json, it's just inconvenient because updating the game overwrites the file every time and you can't separate it into a mod.

@jkraybill
Copy link
Contributor

@Amoebka - absolutely. I think it would be nice if the defaults were separated into a few different classes of markers and colors. I took a look at all the markers and I think a handful of different character markers with a few colors each would be pretty viable. I'm not going to do anything about it for now but can take a pass post-0.E if this issue is still open.

@KurzedMetal
Copy link
Contributor

KurzedMetal commented Mar 30, 2020

As mentioned, you can already customize marks and colors by editing map_extras.json, it's just inconvenient because updating the game overwrites the file every time and you can't separate it into a mod.

This needs to be in the UI (pref in "Autonotes Manager") despite we can change it from a file, so everyone can access it (players may not know of this file, or they don't know how or what to change)

@natsirt721 natsirt721 changed the title Allow in-game customization of map extra note styles Allow in-game customization of map extra auto-note styles Mar 30, 2020
@natsirt721
Copy link
Contributor Author

natsirt721 commented Apr 9, 2020

I'm going to take a stab at this one, should be a pretty easy way to dip my toes into the codebase. Will be gathering feedback about UI on the discord

@stale
Copy link

stale bot commented May 9, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@stale stale bot added the stale Closed for lack of activity, but still valid. label May 9, 2020
@stale
Copy link

stale bot commented Jun 8, 2020

This issue has been automatically closed due to lack of activity. This does not mean that we do not value the issue. Feel free to request that it be re-opened if you are going to actively work on it

@stale stale bot closed this as completed Jun 8, 2020
@kevingranade
Copy link
Member

This issue has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/editing-autonotes-styles-how-to-override-without-touching-data-json/24524/1

@int-ua
Copy link
Contributor

int-ua commented Aug 27, 2020

There is a solution now available at the aforementioned forum thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Info / User Interface Game - player communication, menus, etc. Map / Mapgen Overmap, Mapgen, Map extras, Map display stale Closed for lack of activity, but still valid. <Suggestion / Discussion> Talk it out before implementing
Projects
None yet
Development

No branches or pull requests

7 participants