Cooking improperly shows rotten ingredient as usable.

[sharkfinsouperman]

Describe the bug

When cooking, some rotten ingredients are shown as candidates, though they are correctly not given as options when selecting the final ingredients.

This may be related to issue #38271 and/or a number of others involving rotten ingredients.

Steps To Reproduce

In my case, have numerous usable ingredients and one or more rotten ones, and then proceed to cook the meal.

Expected behavior

The unusable candidate should not be shown, or it should be browned out to indicate rot.

Screenshots

I'm making "cullen skink" with a gallon of rotten milk in the freezer. Note that it is in green as a candidate, though not in the list of choices.

Versions and configuration

• OS: Windows
  • OS Version: MINGW/CYGWIN/MSYS2 on unknown Windows version
• Game Version: 0.D-12648-g63d3fb8 [64-bit]
• Graphics Version: Tiles
• Mods loaded: [
  Dark Days Ahead [dda],
  No Fungal Monsters [No_Fungi]
  ]

[jkraybill]

Definitely related to #38271 / #38295 and #38392 but may be a different issue. I will take a look at this after #38295 gets merged.

[sharkfinsouperman]

There are a few closed PRs that implemented the use of rotten ingredients and I'm wondering if one of those started this series of bugs.

I'd take a look at the PRs myself, but its been more than a decade since I last coded any C++, so I doubt it would do any good. "Skill rust", don't ya know?

[jkraybill]

Just re-tested with the merged PR's noted, and it's still an issue.

[jkraybill]

I've looked at this, I don't have a great solution and I think this should be considered working as designed. Fixing this is not as simple as filtering out rotten ingredients from the list of possible ingredients, because when you do batch-crafting, you can "dip into" the rotten ingredients, and you get properly warned this is going to happen (in this case, the 2 shelf stable milk are OK, the normal milk is not):

There's a more basic repro case, which is if you have a mix of rotten scraps of meat and non-rotten scraps of meat, and go to craft "cooked scrap of meat", you see both the rotten and non-rotten in the count: (here I have 10 rotten and 11 non-rotten):

Cooking a single batch will always use the non-rotten scrap, but if you go to batch view, you do correctly see the rotten/non-rotten item border:

So, I think I've talked myself into "this is working as designed" because I don't see a great way to break out combinations of rotten and non-rotten ingredients in the components menu, and when you see this, it is correct to show those in the "potential ingredients" list because those ingredients will be used if you dip past the non-rotten components.

If anything, maybe there could be a new color code for "using all of this stack will result in rotten components being used" but I can't think of a way to do that which wouldn't be confusing?

[kevingranade]

I'm not sure it's WAI, does cooking this recipe with rotten ingredients yield a usable result? If not, then they should be filtered out.

I'm also questioning more and more whether the use case of obscure crafting recipes that accept rotten ingredients is worth all the trouble this causes. What's the ACTUAL impact of just removing the rotten ingredients as options?

[sharkfinsouperman]

Is the use of rotten ingredients intentional? If so, for which recipe(s)?

The only two I found in the game that could use them in RL are cheese and cured hides/pelts, and those are a stretch. As I've said before, there are places that do use rotting milk in dairy fermentation such Belgium and Mongolia, but those are not typical U.S. "hard cheeses". You can also tan a rotting hide or pelt, but that would result in a weak, low quality end product suited for very little.

IMO, neither fresh milk or sources of leather and fur are nearly as difficult to find as they once were, so I see no reason why the use of rotting ingredients can't be removed all together without causing any major impact.

[kevingranade]

I think it was even more obscure things like some weird chemical thing, or possibly cooking rotten ingredients allowed if the cook is capable of eating rotted food.

[sharkfinsouperman]

If it was intended to enable the ability cook with and eat rotted food, it failed because it results in several exploits that include "fresh" food from spoiled and the ability to turn rotting hides and pelts into quality leather and fur.

I was unable to find the PR the implemented it, and I've no idea which chemical reaction is so important that rotted ingredients need to be allowed.

IMO, the whole rotted ingredient thing should be axed so, maybe, these exploits and bugs can be fixed, and if the need arises that it needs to be re-implemented again, it should be done a different way to prevent these issue from happening again.

Does anyone even know where the code allows the use of rotted ingredients?