Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document ammo_effects property #38412

Closed
snipercup opened this issue Feb 27, 2020 · 1 comment · Fixed by #60534
Closed

Document ammo_effects property #38412

snipercup opened this issue Feb 27, 2020 · 1 comment · Fixed by #60534
Labels
<Documentation> Design documents, internal info, guides and help. (P5 - Long-term) Long-term WIP, may stay on the list for a while.

Comments

@snipercup
Copy link
Contributor

Is your feature request related to a problem? Please describe.

The property ammo_effects used in guns is not documented

Describe the solution you'd like

Document ammo_effects property

Describe alternatives you've considered

Not documenting

Additional context

I think it's strange that the watercannon uses the RECOVER_10 flag in ammo_effects and not flags. The same can be seen in #36955. That's why the documentation should tell me if that's valid.
@ZhilkinSerg
Copy link
Contributor

ammo_effects are basically specific flags. Their properties started to be moved to JSON only recently in #36919.

@ZhilkinSerg ZhilkinSerg added (P5 - Long-term) Long-term WIP, may stay on the list for a while. <Documentation> Design documents, internal info, guides and help. labels Feb 27, 2020
@weekly-digest weekly-digest bot mentioned this issue Mar 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
<Documentation> Design documents, internal info, guides and help. (P5 - Long-term) Long-term WIP, may stay on the list for a while.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ammo effects documentation update
2 participants
@ZhilkinSerg @snipercup