Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update martialart_json.md #38373

Closed
snipercup opened this issue Feb 26, 2020 · 3 comments
Closed

Update martialart_json.md #38373

snipercup opened this issue Feb 26, 2020 · 3 comments
Labels
<Documentation> Design documents, internal info, guides and help. (P5 - Long-term) Long-term WIP, may stay on the list for a while.

Comments

@snipercup
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Some properties used in the martial_art type are not documented.

Describe the solution you'd like

Document the following properties:
primary_skill
strictly_melee
arm_block_with_bio_armor_arms
arm_block_with_bio_armor_legs
force_unarmed
ongethit_buffs

The static_buffs is noted as an array but then continues to use keys as values, as though it was an object. Should be fixed by adding { at the start and } at the end of the key/value pairs

leg_block refers to arms instead of legs in its description

Describe alternatives you've considered

Not documenting

@Night-Pryanik Night-Pryanik added the <Documentation> Design documents, internal info, guides and help. label Feb 26, 2020
@Nugget-Meister
Copy link

knockback_follow claims to use an int, game asks for a bool.

image

image

@stale
Copy link

stale bot commented Mar 30, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@stale stale bot added the stale Closed for lack of activity, but still valid. label Mar 30, 2020
@kevingranade kevingranade added the (P5 - Long-term) Long-term WIP, may stay on the list for a while. label Mar 31, 2020
@stale stale bot removed the stale Closed for lack of activity, but still valid. label Mar 31, 2020
@Fris0uman
Copy link
Contributor

closed by #68418

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Documentation> Design documents, internal info, guides and help. (P5 - Long-term) Long-term WIP, may stay on the list for a while.
Projects
None yet
Development

No branches or pull requests

5 participants