Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examining NPC's dropped weapon after killing them gives error #38225

Closed
CoroNaut opened this issue Feb 22, 2020 · 2 comments · Fixed by #38334
Closed

Examining NPC's dropped weapon after killing them gives error #38225

CoroNaut opened this issue Feb 22, 2020 · 2 comments · Fixed by #38334
Labels
<Bug> This needs to be fixed Items / Item Actions / Item Qualities Items and how they work and interact NPC / Factions NPCs, AI, Speech, Factions, Ownership

Comments

@CoroNaut
Copy link

Describe the bug

Get error when picking up a dropped npcs weapon after killing them

Steps To Reproduce

  1. Spawn npcand immediately chat with them and get them to drop their weapon immediately
  2. Kill said npc
  3. Try to pick up the dropped weapon
  4. Error

Expected behavior

No error

Versions and configuration

  • OS: Windows
    • OS Version: MINGW/CYGWIN/MSYS2 on unknown Windows version
  • Game Version: 0.D-12476-gfef327b [64-bit]
  • Graphics Version: Tiles
  • Mods loaded: [
    Dark Days Ahead [dda],
    No Fungal Monsters [No_Fungi],
    Disable Religious Texts [no_religious_Texts]
    ]
    Mods loaded: [e.g.dda, boats, hacktheplanet, StatsThroughSkills]
@CoroNaut CoroNaut changed the title Examining NPC's dropped weapon and killing them gives error Examining NPC's dropped weapon after killing them gives error Feb 22, 2020
@wapcaplet
Copy link
Contributor

wapcaplet commented Feb 22, 2020

Duplicate of #37339

Thanks for reporting, it is good to know someone else can reproduce the issue besides me.

@kevingranade kevingranade added the (S3 - Duplicate) Bug that is duplicate of another one label Feb 22, 2020
@ghost
Copy link

ghost commented Feb 25, 2020

Different issue, this one is still valid, the other isnt.
When an NPC drops a weapon, it retains their ownership, and when they die, it only removes the ownership on the items they have on their inventory.

The fix for this would be to either just silently remove ownership on examine when the faction is discovered to be nonvalid.

@ghost ghost reopened this Feb 25, 2020
@ghost ghost added <Bug> This needs to be fixed Items / Item Actions / Item Qualities Items and how they work and interact NPC / Factions NPCs, AI, Speech, Factions, Ownership and removed (S3 - Duplicate) Bug that is duplicate of another one labels Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Items / Item Actions / Item Qualities Items and how they work and interact NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants