Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gaps in map memory #37318

Closed
chaoticidealism opened this issue Jan 23, 2020 · 4 comments · Fixed by #37460
Closed

Gaps in map memory #37318

chaoticidealism opened this issue Jan 23, 2020 · 4 comments · Fixed by #37460
Labels
<Bug> This needs to be fixed Mechanics: Map Memory Performance issues, weird behavior, improvements to map memory feature

Comments

@chaoticidealism
Copy link

chaoticidealism commented Jan 23, 2020

When exploring, sometimes there are gaps in what the character remembers on the map. I don't mean that they eventually forget it; I mean that they never remember it to begin with. See attached file for an example.

Steps To Reproduce

Start a game, explore some, and notice that there are places that can't be remembered. This is especially noticeable in large structures, but will happen in one-tile houses too.

Expected behavior

Map memory shouldn't have gaps.

Screenshots

Screenshot_4
This is a mine level, fully explored except for the spot behind the poison gas. The stairs are off to the left side of the screen; the character entered through those stairs and explored the level. There is a memory gap right next to the stairs, and two more square gaps above the character.

Versions and configuration

  • OS: Windows
    • OS Version: 10.0 1909
  • Game Version: 0.D-11543-g3e11834 [64-bit]
  • Graphics Version: Tiles
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    C.R.I.T Expansion Mod [crt_expansion],
    Magiclysm [magiclysm],
    Garden Pots [growable-pots],
    Generic Guns [generic_guns],
    Makeshift Items Mod [makeshift],
    More Survival Tools [More_Survival_Tools],
    DinoMod [DinoMod],
    Modular Turrets [modular_turrets],
    Salvaged Robots [Salvaged_Robots],
    EZ-Mode Medical [fast_healing],
    Hydroponics [hydroponics],
    Mutant NPCs [mutant_npcs],
    My Sweet Cataclysm [my_sweet_cataclysm],
    Mythical Martial Arts [MMA],
    No Fictional Guns [no_rivtech_guns],
    No Flaming Weapons [no_flaming_weapons],
    Classes and Scenarios Mod [more_classes_scenarios],
    Safe Autodoc [safeautodoc],
    Manual Bionic Installation [manualbionicinstall],
    SpeedyDex [speedydex],
    Stats Through Kills [stats_through_kills]
    ]
@shadowsapex
Copy link

I was able to fix the map memory temporarily by quitting out and back in

@chaoticidealism
Copy link
Author

I was able to fix the map memory temporarily by quitting out and back in

Good to know, at least there's a temporary fix.

@kevingranade
Copy link
Member

Based on the symptoms it's something to do with the top level map memory cache. A tile is only eligible to be memorized the first time you see it, and it's ignored after that, so if you can somehow see a tile but it doesn't draw a memorize-able symbol, it will record nothing.

@chaoticidealism
Copy link
Author

Based on the symptoms it's something to do with the top level map memory cache. A tile is only eligible to be memorized the first time you see it, and it's ignored after that, so if you can somehow see a tile but it doesn't draw a memorize-able symbol, it will record nothing.

So maybe the best way to track this one down is to see when the "see a tile" function is called, and then figure out which instances of it don't come with a "memorize tile" afterward?

@ifreund ifreund added <Bug> This needs to be fixed Mechanics: Map Memory Performance issues, weird behavior, improvements to map memory feature labels Jan 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Mechanics: Map Memory Performance issues, weird behavior, improvements to map memory feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants