Heavy Disposable Batteries recharging through exploit.

[gwyter]

Describe the bug

Heavy Disposable Batteries are rechargeable when loaded into an UPS and placed over a working recharging station.

Steps To Reproduce

1. Load an UPS with a heavy disposable battery.
2. Spend some charge (shooting, using tools, anything that drains power from the battery from 100% to something else.)
3. Place the Disposable Battery-loaded UPS on a working recharging station.

Expected behavior

UPS wouldn't charge, as the disposable battery itself can't be recharged when not loaded to an UPS.

Versions and configuration

• OS: Linux
  • OS Version: LSB Version: n/a; Distributor ID: ManjaroLinux; Description: Manjaro Linux; Release: 18.1.5; Codename: Juhraya;
• Game Version: 0.D-11533-g12beec0 [64-bit]
• Graphics Version: Tiles
• Mods loaded: [Dark Days Ahead [dda], Disable NPC Needs [no_npc_food], Aftershock [aftershock]]

[Inglonias]

The easiest fix for this would be to disallow charging the UPS altogether. Is that acceptable, or is a more in-depth fix required?

To clarify, you would be able to charge batteries in a charging station, but not tools.

[gwyter]

@Inglonias I don't see any downside to that, other than a few more key presses to recharge non-disposable batteries used for an UPS

[gwyter]

@Inglonias looking further into the issue, I think it comes from Aftershock, checking it's files, the ups differs in having the RECHARGE flag in Aftershock but not in Dda, so when I get home I'll try to remove that and test

[Inglonias]

That might explain why I missed this, yeah.