Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory not connecting walls properly #36609

Closed
CoroNaut opened this issue Jan 1, 2020 · 5 comments · Fixed by #37460
Closed

Memory not connecting walls properly #36609

CoroNaut opened this issue Jan 1, 2020 · 5 comments · Fixed by #37460
Labels
<Bug> This needs to be fixed Mechanics: Map Memory Performance issues, weird behavior, improvements to map memory feature

Comments

@CoroNaut
Copy link

CoroNaut commented Jan 1, 2020

Describe the bug

Map memory would usually keep the same tile as what you saw, but in this case it seems that some tiles are changing between map memory and normal vision

Steps To Reproduce

Steps to reproduce the behavior:

  1. Find natural occurrence of such a tile (probably best in lab in the same section as pictures)

Expected behavior

Map memory is a record of what normal vision sees

Screenshots

The only weird tiles are the ones below the character and right at the top with just a couple problem connections.

Picture showing walls below character are blocks instead of connected walls
Capture2

Normal vision of the connected walls
Capture3

Versions and configuration

  • OS: Windows
    • OS Version: MINGW/CYGWIN/MSYS2 on unknown Windows version
  • Game Version: 0.D-10922-gb1541cd [32-bit]
  • Graphics Version: Tiles
  • Mods loaded: [
    Dark Days Ahead [dda],
    No Fungal Monsters [No_Fungi],
    Disable Religious Texts [no_religious_Texts]
    ]
@Qrox
Copy link
Contributor

Qrox commented Jan 1, 2020

The only reason I can think of is that map memory connection was not correctly calculated when memorizing the tiles, but I'm not able to reproduce it. Have you previously entered the bottom aisle? Were you there with low light level?

@kevingranade
Copy link
Member

I think you're right, it memorizes the wall as drawn the first time you see it, but it doesn't get updated once you see the wall next to it that adjusts what tile is drawn there.

@Qrox
Copy link
Contributor

Qrox commented Jan 1, 2020

Well, it always calculate the connection according to nearby tiles even if you can't see them, so I don't known why would the connection be wrong in the first place.

@kevingranade
Copy link
Member

I'm pretty sure it doesn't, that would leak information.

@Qrox
Copy link
Contributor

Qrox commented Jan 2, 2020

You're right, I didn't reproduce it because the tileset I was using doesn't have edges on the wall tiles, so it looked as if it calcuated connection according to nearby tiles.

@Night-Pryanik Night-Pryanik added <Bug> This needs to be fixed Mechanics: Map Memory Performance issues, weird behavior, improvements to map memory feature labels Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Mechanics: Map Memory Performance issues, weird behavior, improvements to map memory feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants