Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange issue with counterattacks causing massive damage to player's arm #36517

Closed
Kelenius opened this issue Dec 28, 2019 · 2 comments · Fixed by #36704
Closed

Strange issue with counterattacks causing massive damage to player's arm #36517

Kelenius opened this issue Dec 28, 2019 · 2 comments · Fixed by #36704
Labels
<Bug> This needs to be fixed [C++] Changes (can be) made in C++. Previously named `Code` Good First Issue This is a good first issue for a new contributor Items / Item Actions / Item Qualities Items and how they work and interact Melee Melee weapons, tactics, techniques, reach attack

Comments

@Kelenius
Copy link
Contributor

Kelenius commented Dec 28, 2019

Describe the bug

Being attacked by a monster while wielding a large item and counterattacking breaks your arm.

Steps To Reproduce

Steps to reproduce the behavior:

  1. Be a survivor with high skills, capable of counterattacking.
  2. Hold a large item (I encountered this issue with rotary evapourator).
  3. Stand next to a monster (giant cockroach in my case) and get attacked until you counter.

Expected behavior

?????

Screenshots

изображение
изображение
изображение
изображение
(It doesn't happen every time, to these are different games)

Versions and configuration

  • OS: Windows
    • OS Version: 10.0 1903
  • Game Version: 0.D-10735-gd136e46 [64-bit]
  • Graphics Version: Tiles
  • Mods loaded: [
    Dark Days Ahead [dda],
    Vehicle Additions Pack [blazemod],
    Folding Parts pack [deoxymod],
    No Acid Zombies [No_Acid_Zombies],
    No Fungal Monsters [No_Fungi],
    Prevent Zombie Revivication [no_reviving_zombies]
    ]

Additional context

Franklinville.zip

I suspect that counterattacks somehow multiply damage by the time it takes to perform it, and because huge item = lots of time spent attacking, that translates into massive damage somehow, because I'm also dealing 300+ damage to the roach with one attack, way over what I should be capable of. Also, the messages say that the rotary evapourator shatters, which doesn't happen.

@kevingranade
Copy link
Member

This is getting triggered by the item "shattering" since it's made of glass, and the damage scales with item volume.

if( is_player() ) {

There is a secondary issue in that counterattacks shouldn't be triggering with such a large (and more importantly, slow) item.

@kevingranade kevingranade added <Bug> This needs to be fixed [C++] Changes (can be) made in C++. Previously named `Code` Good First Issue This is a good first issue for a new contributor Items / Item Actions / Item Qualities Items and how they work and interact Melee Melee weapons, tactics, techniques, reach attack labels Dec 29, 2019
@Soup-de-Loop
Copy link
Contributor

This was an interesting one, I actually had it happen recently when trying to carry a rotary evapourator out of a Research Lab. Z got too close, had far more pain than I thought from such a small encounter and badaboom, right arm completely mangled and requiring a splint. Good to know why, now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed [C++] Changes (can be) made in C++. Previously named `Code` Good First Issue This is a good first issue for a new contributor Items / Item Actions / Item Qualities Items and how they work and interact Melee Melee weapons, tactics, techniques, reach attack
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants