Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Items have more mass than the sum of their parts #36399

Open
Bejofo opened this issue Dec 24, 2019 · 1 comment
Open

Items have more mass than the sum of their parts #36399

Bejofo opened this issue Dec 24, 2019 · 1 comment
Labels
<Bug> This needs to be fixed [C++] Changes (can be) made in C++. Previously named `Code` Game: Balance Balancing of (existing) in-game features. Items / Item Actions / Item Qualities Items and how they work and interact

Comments

@Bejofo
Copy link
Contributor

Bejofo commented Dec 24, 2019

Describe the bug

Some items in game seem to defy conservation of matter when disassembled or assembled

Steps To Reproduce

Steps to reproduce the behavior:

  1. Disassemble a sand bag.
  2. Note the decreased mass ( 24.41 kg-> 0.49 kg)

Expected behavior

Things to remain more or less similar in mass.

Versions and configuration

  • OS: Windows
    • OS Version: 10.0 1903
  • Game Version: 0.D-9376-gb17746f [64-bit]
  • Graphics Version: Tiles
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Mythical Martial Arts [MMA],
    EZ-Mode Medical [fast_healing],
    Hydroponics [hydroponics],
    Mutant NPCs [mutant_npcs],
    Vehicle Additions Pack [blazemod],
    Roadheader and other mining vehicles [Heavy miners],
    Folding Parts pack [deoxymod],
    Tanks and Other Vehicles [Tanks],
    Aftershock [aftershock],
    Craftable Gun Pack [craftgp],
    DeadLeaves' Fictional Guns [FIC_Weapons],
    Icecoon's Arsenal [ew_pack],
    Makeshift Items Mod [makeshift],
    Medieval and Historic Classes and Shields [Medieval_Stuff],
    More Survival Tools [More_Survival_Tools],
    Mundane Zombies [Mundane_Zombies],
    No Acid Zombies [No_Acid_Zombies],
    No Ants [No_Anthills],
    No Bees [No_Bees],
    No Monsters [Only_Wildlife],
    No Fungal Monsters [No_Fungi],
    No Big Zombies [No_Big_Zombies],
    No Explosive Zombies [No_Explosive_Zombies],
    No Spiders [No_Spiders],
    Whitelist [Whitelist],
    Classes and Scenarios Mod [more_classes_scenarios],
    Classic Roguelike Classes [RL_Classes],
    Fuji's Military Profession Pack [fuji_mpp],
    Manual Bionic Installation [manualbionicinstall],
    No Filthy Clothing [no_filthy_clothing],
    Prevent Zombie Revivication [no_reviving_zombies],
    Safe Autodoc [safeautodoc],
    Simplified Nutrition [novitamins],
    No Rail Stations [No_Rail_Stations]
    ]

Additional context

I wrote a script to try and find other such cases.
I'am fairly certain it missed quite a few, and some of the numbers are off, but I think it's a start.

Item Weight Calculated weight (g) Actual weight (g) Δ (g) Percent diff
washing_machine 8093 31752 23659 292.34
sandbag 895 24415 23520 2627.93
amplifier_head 1323 11339 10016 757.07
hard_plate 24000 32640 8640 36.00
multi_cooker 2728 11339 8611 315.65
welder_crude 1002 7250 6248 623.55
blunderbuss 2741 8267 5526 201.61
steel_plate 8000 12880 4880 61.00
extinguisher 5509 9071 3562 64.66
voltmeter 468 3000 2532 541.03
fan 329 2857 2528 768.39
char_smoker 1005 2600 1595 158.71
coilgun 1817 3341 1524 83.87
oxygen_tank 900 2268 1368 152.00
sm_extinguisher 900 2267 1367 151.89
rifle_223 2741 4080 1339 48.85
camera_pro 978 2268 1290 131.90
leather_harness_dog 997 2145 1148 115.15
vac_sealer 1309 2449 1140 87.09
@snipercup
Copy link
Contributor

Nice, I did a similar thing with the weight analyser in https://github.com/snipercup/CCDA-JS-data-browser except from a recipe perspective, looks like you are coming from a disassemble perspective. I did some balancing then, for example #34916. It all spawned from issue #33327.

Basically you want the item to conseve mass when constructing and deconstructing. You already indexed some items where the mass is not preserved in deconstructing. In issue #33327 there was talk of enforcing the conservation of mass trough c++ but I only invested in balancing the current items in preperation for that.

@kevingranade kevingranade added <Bug> This needs to be fixed [C++] Changes (can be) made in C++. Previously named `Code` Game: Balance Balancing of (existing) in-game features. Items / Item Actions / Item Qualities Items and how they work and interact labels Dec 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed [C++] Changes (can be) made in C++. Previously named `Code` Game: Balance Balancing of (existing) in-game features. Items / Item Actions / Item Qualities Items and how they work and interact
Projects
None yet
Development

No branches or pull requests

3 participants