Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0,0,0 map tile full of items: soil,tools,steel barrels #34776

Closed
int-ua opened this issue Oct 15, 2019 · 11 comments · Fixed by #35262
Closed

0,0,0 map tile full of items: soil,tools,steel barrels #34776

int-ua opened this issue Oct 15, 2019 · 11 comments · Fixed by #35262
Labels
<Bug> This needs to be fixed Character / World Generation Issues and enhancements concerning stages of creating a character or a world Map / Mapgen Overmap, Mapgen, Map extras, Map display (S2 - Confirmed) Bug that's been confirmed to exist

Comments

@int-ua
Copy link
Contributor

int-ua commented Oct 15, 2019

Describe the bug

Yesterday experimental:
2019-10-15-171446_1920x1080_scrot

Steps To Reproduce

Steps to reproduce the behavior:

  1. Teleport to 0,0,0 in any of your latest experimental saves.

Expected behavior

Usual random tile.

Versions and configuration

  • OS: Linux
    • OS Version: Distributor ID: Ubuntu; Description: Ubuntu 18.04.3 LTS; Release: 18.04; Codename: bionic;
  • Game Version: 0.D-8520-gcb7938e [64-bit]
  • Graphics Version: Tiles
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    More Survival Tools [More_Survival_Tools],
    Disable Religious Texts [no_religious_Texts],
    No Antique Firearms [no_olg_guns]
    ]
@ZhilkinSerg
Copy link
Contributor

Similar to #31648

@ZhilkinSerg ZhilkinSerg added (S1 - Need confirmation) Report waiting on confirmation of reproducibility Character / World Generation Issues and enhancements concerning stages of creating a character or a world Map / Mapgen Overmap, Mapgen, Map extras, Map display labels Oct 15, 2019
@ZhilkinSerg
Copy link
Contributor

Did you use any mods when starting game that you have changed before loading a savegame? Is it reproducible in new games too?

@ZhilkinSerg ZhilkinSerg added (S2 - Confirmed) Bug that's been confirmed to exist and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels Oct 15, 2019
@ZhilkinSerg
Copy link
Contributor

ZhilkinSerg commented Oct 15, 2019

It can be reproduced back to build 9141, thus it was most probably caused by #31295.

I stand corrected - bisect says it is #31115.

@ZhilkinSerg ZhilkinSerg added the <Bug> This needs to be fixed label Oct 15, 2019
@int-ua
Copy link
Contributor Author

int-ua commented Oct 15, 2019

No mods removal, first save I got this on was as vanilla as it gets: Play now was the first thing with config dir empty.

@AMurkin
Copy link
Contributor

AMurkin commented Oct 15, 2019

(0,0,0) in my world
image
modlist:

[
  "dda",
  "no_npc_food"
]

@mlangsdorf
Copy link
Contributor

It's clearly the blueprint_autocalc code gone crazy. I wonder why this suddenly started appearing?

@ZhilkinSerg
Copy link
Contributor

It's clearly the blueprint_autocalc code gone crazy. I wonder why this suddenly started appearing?

It started long time ago in #31115

@fluffe9911
Copy link
Contributor

fluffe9911 commented Oct 15, 2019

Oh yeah I noticed this while running away from zombies like a month ago just figured it was one of those unmarked easter egg things you can find on the map like that cabin with the grave.

@ghost
Copy link

ghost commented Oct 16, 2019

I actually thought that was an easter egg too... like an abandoned base/unfinished base judging by all the tools and materials scattered about.

If there is a way to convert it into an actual, balanced map extra I'll be down with it.

@Little-119
Copy link

It's not a bug, it's a Feature™

@mlangsdorf
Copy link
Contributor

mlangsdorf commented Oct 16, 2019

Possible solution:
in get_changed_ids_from_update(), add a second tinymap called real_map. before calling fake_map.fake_load(), call real_map.load() to stash the original map data. A the end of the function, explicitly save real_map which should save the original, unchanged map back to disk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Character / World Generation Issues and enhancements concerning stages of creating a character or a world Map / Mapgen Overmap, Mapgen, Map extras, Map display (S2 - Confirmed) Bug that's been confirmed to exist
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants