Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smartphones won't show the time when music is played from them #34563

Closed
Lamandus opened this issue Oct 8, 2019 · 3 comments · Fixed by #34573
Closed

Smartphones won't show the time when music is played from them #34563

Lamandus opened this issue Oct 8, 2019 · 3 comments · Fixed by #34573
Labels
Good First Issue This is a good first issue for a new contributor Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON

Comments

@Lamandus
Copy link
Contributor

Lamandus commented Oct 8, 2019

When using a Smartphone for Musiclistening, you loose the possibility to check the time.

Steps to reproduce the behavior:

  1. Take any UPS Smartphone
  2. Check the time when it is not playing musik
  3. Switch on the Music function
  4. Try to check the time again.

Expected behavior

You should check the time even when it plays music.

Screenshots

Smartoff
Smarton

Versions and configuration

dda
Version 9730

@curstwist
Copy link
Contributor

also when using the light.

@AMurkin
Copy link
Contributor

AMurkin commented Oct 8, 2019

{
"id": "smart_phone",
"type": "TOOL",
"name": "smartphone",
"name_plural": "smartphones",
"description": "A popular, fancy smartphone. Capable of making photos due to integrated camera and illuminating an area as per flashlight app, assuming it has enough charge. The smartphone also has a clock app that includes an alarm. Runs on a small, rechargeable power cell compatible with Unified Power Supply.",
"weight": "230 g",
"volume": "100 ml",
"price": 20000,
"price_postapoc": 1900,
"material": [ "plastic", "aluminum" ],
"looks_like": "cell_phone",
"symbol": ";",
"color": "light_gray",
"ammo": "battery",
"initial_charges": 110,
"max_charges": 120,
"charges_per_use": 1,
"use_action": [
{
"target": "smart_phone_flashlight",
"msg": "You activate the flashlight app.",
"active": true,
"need_charges": 5,
"need_charges_msg": "The smartphone's charge is too low.",
"type": "transform"
},
"CAMERA",
"MP3"
],
"flags": [ "WATCH", "ALARMCLOCK", "USE_UPS", "NO_UNLOAD", "NO_RELOAD" ]
},
{
"id": "smartphone_music",
"copy-from": "smart_phone",
"type": "TOOL",
"name": "smartphone - music",
"name_plural": "smartphones - music",
"description": "This phone is playing music, steadily raising your morale. You can't hear anything else while you're listening.",
"power_draw": 300,
"revert_to": "smart_phone",
"use_action": "MP3_ON",
"flags": [ "TRADER_AVOID" ],
"magazine_well": 1
},
{
"id": "smart_phone_flashlight",
"copy-from": "smart_phone",
"type": "TOOL",
"name": "smartphone - Flashlight",
"name_plural": "smartphones - Flashlight",
"power_draw": 500,
"revert_to": "smart_phone",
"use_action": {
"target": "smart_phone",
"msg": "You deactivate the flashlight app.",
"menu_text": "Turn off flashlight",
"type": "transform"
},
"flags": [ "LIGHT_20", "CHARGEDIM", "TRADER_AVOID" ]
},

Smartphone flags:
"flags": [ "WATCH", "ALARMCLOCK", "USE_UPS", "NO_UNLOAD", "NO_RELOAD" ]
smartphone_music flags:
"flags": [ "TRADER_AVOID" ],
smart_phone_flashlight flags:
"flags": [ "LIGHT_20", "CHARGEDIM", "TRADER_AVOID" ]

@Lamandus
Copy link
Contributor Author

Lamandus commented Oct 8, 2019

so if the flag "WATCH" is added to those two other lines, it is fixed, right? Can someone do it pleaaase?

@KorGgenT KorGgenT added [JSON] Changes (can be) made in JSON Good First Issue This is a good first issue for a new contributor Items / Item Actions / Item Qualities Items and how they work and interact labels Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue This is a good first issue for a new contributor Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants