Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multicooker crashes the game #33593

Closed
CCorvet opened this issue Aug 27, 2019 · 2 comments · Fixed by #34253
Closed

Multicooker crashes the game #33593

CCorvet opened this issue Aug 27, 2019 · 2 comments · Fixed by #34253
Labels
<Crash / Freeze> Fatal bug that results in hangs or crashes. Items / Item Actions / Item Qualities Items and how they work and interact (S2 - Confirmed) Bug that's been confirmed to exist
Milestone

Comments

@CCorvet
Copy link
Contributor

CCorvet commented Aug 27, 2019

Describe the bug

When using the Multicooker (from the inventory, not from the crafting menu), the game crashes

Steps To Reproduce

Steps to reproduce the behavior:

  1. Spawn a Multicooker and ingredients for any recipe compatible with it's auto-cooking
  2. Use the Multicooker and try to choose a recipe (Whether with the bulk craft button or enter)
  3. Crash

Expected behavior

I have never successfully used it before. However i assume that after a time delay the food item is crafted and the Multicooker looses some charge.

Screenshots

If applicable, add screenshots to help explain your problem.

Versions and configuration

  • OS: Windows
    • OS Version: 10.0 1903
  • Game Version: 0.D-7009-gd8f806f [64-bit]
  • Graphics Version: Tiles
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food]
    ]

Additional context

Test World.zip
Crash + Debug.zip

@Night-Pryanik Night-Pryanik added (S1 - Need confirmation) Report waiting on confirmation of reproducibility <Crash / Freeze> Fatal bug that results in hangs or crashes. Items / Item Actions / Item Qualities Items and how they work and interact labels Aug 27, 2019
@MarcNuernberger
Copy link

Can confirm that. Tried it with the provided savegame and afterwards with a fresh world and character too. In both cases the game crashed after selecting the recipe with the multi cooker.

@SchillingCodes
Copy link
Contributor

SchillingCodes commented Aug 27, 2019

I also tried it with the save file and my game crashed after selecting the recipe "cooked meat."

In Visual Studio I get a "divide by zero" exception cause by the following code in iuse.cpp:
const int all_charges = charges_to_start + mealtime / ( it->type->tool->turns_per_charge * 100 );

Looking in data/json/items/tools.json, I see multi_cooker doesn't have a "turns_per_charge" key, so it is set to zero by default. I don't what this value should be, but I tested with a value of 1 and the game doesn't crash, just tells me I need more charges to use it.

I'm new to contributing to this project and github in general, so hopefully this is all good. Don't know if I should have waited for the S2 label.

@Night-Pryanik Night-Pryanik added (S2 - Confirmed) Bug that's been confirmed to exist and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels Aug 28, 2019
@ZhilkinSerg ZhilkinSerg added this to the 0.E milestone Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Crash / Freeze> Fatal bug that results in hangs or crashes. Items / Item Actions / Item Qualities Items and how they work and interact (S2 - Confirmed) Bug that's been confirmed to exist
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants