Character creation crash

[harwoodr]

Describe the bug

Game gives an error during character creation and then aborts character creation.

Steps To Reproduce

Steps to reproduce the behaviour:

1. Select Dark Days Ahead and Aftershock Mods (seems to only be with Aftershock)
2. Try to create a character

Expected behaviour

To create a new character and play with Aftershock Mod loaded

Screenshots

none

Versions and configuration

• OS: Linux
  • OS Version: Distributor ID: Ubuntu; Description: Ubuntu 18.04.2 LTS; Release: 18.04; Codename: bionic;
• Game Version: 0.D-4255-gc42e417478 [64-bit]
• Graphics Version: Tiles
• Mods loaded: [
  Dark Days Ahead [dda],
  Disable NPC Needs [no_npc_food]

This report was generated with default mods... for obvious reasons.

Additional context

DEBUG : Error: basic_string::_M_construct null not valid

FUNCTION : bool main_menu::new_character_tab()
FILE : src/main_menu.cpp
LINE : 709

[scalpelenema]

same here. linux, default mods, crash when loading & creating new character

[harwoodr]

Just tried 9148 and 9147 experimental builds and got same results...

[scalpelenema]

the latest build which worked fine is 9139 I think

[Lucewithnootherideas]

still happening on 9151

[Night-Pryanik]

Seems like a duplicate of #31152.

[harwoodr]

Seems like a duplicate of #31152.

That one has a segfault... and I don't experience this problem with that build.

[mark7]

git-bisect shows the first bad commit to be 64516a6

[mark7]

@ymber and @kevingranade, 64516a6 was your patch and commit, respectively, as a heads-up.

[mark7]

If the laser_rifle part on car_atomic_flame is removed from afs_vehicles.json, the bug also goes away. Note that CrazyCataclysm also has this vehicle.

[mark7]

If the second line in veh_type.cpp modified in 64516a6 is commented out, the bug is also not exhibited:

                 if( pt.ammo_types.empty() ) {
-                    pt.ammo_types.insert( base->gun->ammo->default_ammotype() );
+                    pt.ammo_types.insert( ammotype( *base->gun->ammo.begin() )->default_ammotype() );
                 }