Map exploration is lost on game reload

[tsulh]

Describe the bug

Map exploration is lost on every game reload, both in old and new saves.

Steps To Reproduce

Steps to reproduce the behavior:

1. Create a new character. Look at the map, see that some area is explored.
2. Save and quit.
3. Load the game. Look at the map, see that all map is unexplored.

Expected behavior

The map exploration doesn't get lost.

Screenshots

Versions and configuration

• OS: Linux
  • OS Version: Distributor ID: Debian; Description: Debian GNU/Linux 10 (buster);
• Game Version: 0.D-4248-g94874bc785 [64-bit]
• Graphics Version: Tiles
• Mods loaded: [
  Dark Days Ahead [dda],
  Bionics Systems Mod [bio_mod],
  Makeshift Items Mod [makeshift],
  Garden Pots [growable-pots],
  NPC traits [npc_traits],
  Folding Parts pack [deoxymod],
  Classes and Scenarios Mod [more_classes_scenarios],
  Disable NPC Needs [no_npc_food],
  StatsThroughSkills [StatsThroughSkills]
  ]

Additional context

debug.log
Astoria.zip

[ZhilkinSerg]

Bisecting points to #31115, but I cannot see what could be causing such behavior.

[methanolium]

I can add that in some saves overmap is "shrinked" after load. It looks like only one "chunk" of it (where character is located) is lost. For me (Win64 Tiles) it started in 9148. Everything is fine in 9140.

[jagoly]

reverting just 74d9af4 fixes this, the same commit also seems to cause the issue I'm having where missions get messed up when loading a save

[ZhilkinSerg]

reverting just 74d9af4 fixes this, the same commit also seems to cause the issue I'm having where missions get messed up when loading a save

Thanks for testing this. We will take a closer look into changes in this PR.

[7illian]

Experiencing this as well.

[sdp0et]

Thanks for looking into this. I'm having the issue as well. All but one of about eight reloads had this issue over two worlds/characters. It also removes any map notes. In addition, using a map once removed all knowledge of the nearby map tiles that I currently had explored.

I've also got the mission problem ZhilkinSerg mentioned. The first reload of a save shows this:

16:14:52.790 ERROR : src/mission.cpp:74 [static mission* mission::find(int)] requested mission with uid 2 does not exist
16:14:52.793 ERROR GAME : src/mission.cpp:73: requested mission with uid 2 does not exist

several times with different uids. More than my current number of active/completed missions (maybe the others are missions that would be given out in mission chains?). The missions are still listed for me and I get the marker, but the NPC who gave them stops asking about them so they can't be completed. Subsequent loads don't have that error, so they're probably not being saved after the initial errors making it seem like they've been removed from the NPCs. I tried editing the NPCs missions and they didn't have any and I couldn't see an option to add any new ones to give out.

Is there a way to reveal roads in an overmap without revealing everything? It would be easier to re-find certain places without ruining new exploration by revealing the whole map. Currently I'm using mission markers to get a reference points for finding what I need, but being able to see the roads would make it a little easier to deal with.

[P0NYSLAYSTATION]

I'm having the same issue, can't confirm about missions as I didn't have any. The bug only affects overmap knowledge gained through exploration, everything I know from reading tourist guides, maps etc remains

@sdp0et You could wish yourself maps and guides I think, your knowledge from them is permanent, although you still wont remember any buildings and maps that weren't on the item

Grayburg.zip
debug.log

[Igryn]

Have same issue, no mods exept npc needs toggled off

[Zombiemanpig]

Can confirm this bug is real and super annoying.

I'm having the same issue, can't confirm about missions as I didn't have any. The bug only affects overmap knowledge gained through exploration, everything I know from reading tourist guides, maps etc remains

Yes map knowledge from activating maps remains.

[Zombiemanpig]

This is not fixed @kevingranade I just tested it in 9161.

[ZhilkinSerg]

It was not fixed in 9161 because fix is in 9162.

[xMyrkin]

9161 have #31469 PR... we'll wait and pray for 9162 :)

[Zombiemanpig]

9161 have #31469 PR... we'll wait and pray for 9162 :)

Fixed in 9162, it did say that 9161 was the release with the fix.