Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Historic Content] Crash from lack of messaging when changing martial art styles #30383

Closed
MrHrulgin opened this issue May 10, 2019 · 4 comments

Comments

@MrHrulgin
Copy link
Contributor

MrHrulgin commented May 10, 2019

Describe the bug
When trying to load a character in a world with Medieval and Historic Content you get an error of:

DEBUG : Error: data/mods//Medieval_Stuff/martialarts.json: line 6:286: missing mandatory member "initiate"

and other weapons, preceding the later development of fencing. Designed for combat both unarmored and in armor, it includes grappling as well as defensive and offensive sword techniques, plus familiarity with other weapons like polearms.",
^
"arm_block": 99,
"leg_block": 99,
"onattack_buffs": [

FUNCTION : bool main_menu::load_character_tab()
FILE : src/main_menu.cpp
LINE : 975

and it fails to load character.

To Reproduce
Steps to reproduce the behavior:
Use Medieval & Historic Content, and try to load a character on version 8932 or later which includes #30334.

Expected behavior
No Crash

Additional Context

#30334 added an additional requirement for each martial art to have a message when you switch to that martial art. Something needs to be added to the M&HC martial arts to keep it working. Probably also the venom styles, but I haven't been using it so I dunno.

@Zireael07
Copy link
Contributor

Try to search a bit before filing an issue? One was made an hour ago and closed as dupe.
This is a dupe, too.

@MrHrulgin
Copy link
Contributor Author

MrHrulgin commented May 10, 2019

A: The name of the other issue you closed was entirely opaque regarding the issue. I did search a bit, and nothing showed up that looked like it was referring to this issue.
B: The issue we've reported in the issue tracker was only reported in the thread of the original change that caused this crash, and you closed the other one before I came here to post on the issue so there was no open issue on the topic when I posted mine.
C: This is still an open and active issue that entirely prevents play with M&HC until #30376 is merged, so you can keep closing reports until it's fixed, or you can let there be a single open issue on the topic.

@Zireael07
Copy link
Contributor

Oh, I missed the fact that the original report was just a comment. Reopening then.

@Zireael07 Zireael07 reopened this May 10, 2019
@MrHrulgin MrHrulgin changed the title [Historic Content] Lacks messaging when changing martial art styles [Historic Content] Crash from lack of messaging when changing martial art styles May 10, 2019
@MrHrulgin
Copy link
Contributor Author

Resolved in #30384.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants