dangerous pickup

[communistkiro]

Describe the bug
Having the Dangerous pickups setting in the options enabled should enable auto-pick of items passing the filter despite increasing stamina cost (and perhaps various action movement costs?) for you. This doesn't work for auto-foraged items, which are left on the ground.

To Reproduce
Steps to reproduce the behavior:

1. Have Dangerous pickups: enabled;
2. Turn on any form of auto-forage;
3. Reach carry weight limit;
4. All new to-be-auto-picked-up items remain on tile your char's standing on with the log messages "You harvest and drop %s x%d" and "You see <thing you harvested> x %d here"

Expected behavior
If dangerous pickups is enabled, items that were auto-foraged should be moved to inventory if there is more sufficient volume rather than dropped.

Versions and configuration(please complete the following information):

• Game Version: 0.D-2518-g65a0506
• Graphics version: tiles

[MrHrulgin]

C:DDA doesn't have a soft weight limit with increasing encumbrance, it's a hard limit. There aren't any other circumstances where you can carry more than your limit; why should auto-forage circumvent that?

EDIT: This is only true for volume, as was pointed out below.

[communistkiro]

There are two fractions, carry weight and volume. Exceeding the latter results in items dropping, exceeding the former makes make actions cost more movement points. Both indicated by red.

What I meant with 'overencumbered' is that message one gets when carrying over the carry soft limit, not the encumbrance mechanic. Having reached it, you can carry more foraging results at the cost of faster stamina loss, but you have to pick it up manually.

[MrHrulgin]

You're right, my brain completely slipped a cog. I would imagine that it was put in place to keep people from accidentally overloading themselves, but an option to extensively burden yourself makes sense.

[ifreund]

If dangerous pickups is disabled, items that were auto-foraged should be moved to inventory, rather than dropped.

I think you may have this backwards: enabling not disabling dangerous pickups should cause the behavior you described.

[communistkiro]

@ifreund , my mistake, I'll edit it.