Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dragging a shopping cart leaves a trail of shopping carts behind #28512

Closed
Alapaga opened this issue Mar 6, 2019 · 7 comments
Closed

Dragging a shopping cart leaves a trail of shopping carts behind #28512

Alapaga opened this issue Mar 6, 2019 · 7 comments
Labels
<Bug> This needs to be fixed Mechanics: Map Memory Performance issues, weird behavior, improvements to map memory feature (S2 - Confirmed) Bug that's been confirmed to exist Vehicles Vehicles, parts, mechanics & interactions

Comments

@Alapaga
Copy link

Alapaga commented Mar 6, 2019

Describe the bug
Dragging "G" a shopping cart behind you in night time while the character can only see one tile in each direction causes a visual bug where you can see multiple shopping carts left where the actual shopping cart was in the previous tile

To Reproduce
Drag a shopping cart behind you at nighttime while using a view restrictive item like a motorbike helmet

Expected behavior
I expect my character to "remember" that the shopping cart he saw in the shadows is the one he got his hands on

Screenshots
shopping cart bug

Versions and configuration(please complete the following information):

  • OS: Windows 10
  • Game Version: 0.C-37599-gd5cafd3
  • Graphics version: Tiles
  • Mods loaded: Dark Days Ahead, Filthy clothing, Disable NPC needs, Simplified Nutrition, Generic Guns, More locations, Fuji's More Buildings, Disable Religious Texts, No Fungal Monsters, Manual Bionic Installation, Safe autodoc, StatsThroughSkills

Additional context
manual_backup3.zip
This is a link to a savegame that allows the issue to be reproduced.

@Swootch
Copy link
Contributor

Swootch commented Mar 6, 2019

It's not technically a bug, more of a fallacy that comes from how memory works in this game. I doubt there's an easy way to fix this, you'd have to make every object one can drag be an exception from memory while visual range is equal or less than 1 while being dragged.

@KorGgenT KorGgenT added <Bug> This needs to be fixed Mechanics: Map Memory Performance issues, weird behavior, improvements to map memory feature labels Mar 6, 2019
@kevingranade
Copy link
Member

kevingranade commented Mar 6, 2019 via email

@CoroNaut
Copy link

CoroNaut commented Mar 8, 2019

Perhaps a simple fix is to not allow memory to save any vehicles you are driving or dragging? So if you let go of the cart, and grab it again, it would be in map memory as single tile, and not produce a line afterwards. Similarly with a vehicle, you would hop in and drive somewhere without memory saving any part of the vehicle behind you until you stop controlling, then it will be saved.

@junkyjb
Copy link

junkyjb commented Mar 12, 2019

I have a very similar issue, which I assume is caused by the same thing.

My character is spider mutated, and so has night vision.
When he's pulling one-tile vehicles at night normally this issue doesn't occur, but when he activates a reading light his night-vision reduces to one tile range - resulting in the same ghost traces above.

Though it was worth mentioning, as this wasn't caused by head gear restricting vision, since his Furred Plate mutation prevents him wearing any.

@ZhilkinSerg ZhilkinSerg added Vehicles Vehicles, parts, mechanics & interactions (S2 - Confirmed) Bug that's been confirmed to exist labels Oct 4, 2019
@snipercup
Copy link
Contributor

Perhaps a simple fix is to not allow memory to save any vehicles you are driving or dragging? So if you let go of the cart, and grab it again, it would be in map memory as single tile, and not produce a line afterwards. Similarly with a vehicle, you would hop in and drive somewhere without memory saving any part of the vehicle behind you until you stop controlling, then it will be saved.

I like this idea but what happens when you jump out of a moving vehicle?

@MattD94
Copy link

MattD94 commented Jan 18, 2020

I wanted to add that not only is a trail being created, but it persists even after player can see that the trailed tiles have no vehicle on them - i.e. drag vehicle while crouched, create trail behind, stand-up and see there is no vehicle on those tiles, crouch again and trail reappears. This is on linux64 ncurses build 0.D-11440-g82a2eb2.

Perhaps a simple fix is to not allow memory to save any vehicles you are driving or dragging? So if you let go of the cart, and grab it again, it would be in map memory as single tile, and not produce a line afterwards. Similarly with a vehicle, you would hop in and drive somewhere without memory saving any part of the vehicle behind you until you stop controlling, then it will be saved.

I like this idea but what happens when you jump out of a moving vehicle?

I would think that instead of exempting vehicles/objects from memorization only while driving/grabbing, continue to exempt it if it is still in motion after done driving/grabbing until it comes to a stop or passes completely out of visibility.
Or to state it another way: furniture and vehicles would only be memorized when they are not being grabbed or known to be stationary, respectively.

@wapcaplet
Copy link
Contributor

Cannot reproduce in 0.E-6177-g 9f4a1b8 with UltiCa, RetroDays, or BrownLikeBears tilesets - likely was fixed by #38706. Closing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Mechanics: Map Memory Performance issues, weird behavior, improvements to map memory feature (S2 - Confirmed) Bug that's been confirmed to exist Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

No branches or pull requests

10 participants