Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destruction of clothing with volume #2846

Closed
ianestrachan opened this issue Sep 3, 2013 · 6 comments
Closed

Destruction of clothing with volume #2846

ianestrachan opened this issue Sep 3, 2013 · 6 comments
Labels
<Enhancement / Feature> New features, or enhancements on existing (S2 - Confirmed) Bug that's been confirmed to exist <Suggestion / Discussion> Talk it out before implementing

Comments

@ianestrachan
Copy link
Contributor

Currently, if an item of clothing that provides volume is destroyed, your max volume is lowered. But if you go over the max+2 limit, you're encumbered, but can still carry everything, even if you're 50+ arbitrary units of volume past the limit.

This probably should be changed so that if your backpack gets destroyed while you were at your volume limit, your stuff spills all over the ground.

The items selected should probably be one of the following:

  • randomly
  • largest first
  • equal (or as close as possible) to the amount of volume lost
@kevingranade
Copy link
Member

Agreed, also I'd just prefer to disallow overvolume entirely, just can't
pick extra stuff up at all.
How about drop items randomly, but weighted by volume?

@ianestrachan
Copy link
Contributor Author

Personally, I imagine the +2 leeway (since it's irrelevant to your hands being full) as being equivalent to trying to carry things under your arms. Sure, you can do it, but it's awkward and they are constantly trying to escape and gravity is fighting to steal them from you, and you can't move fast at all.

Randomly (with or without weighting) until you're under your normal limit can work, but in the worst case if you lose 30 volume, you lose a bunch of items until you've lost 29 volume, then suddenly you lose a 30 volume item on top of that and you're down a total of 59 volume of items. Extremely unlikely, of course, but possible.

@kevingranade
Copy link
Member

Prioritize items that fit in the container, so drop random items that fit
in the container until we're under capacity or we're out of items, then
start dropping larger items at random. Can't exclude items that don't
"fit" entirely, because there might not be any such items.
(By random I still mean weighted by volume, otherwise you'll always drop
half your medicines, you know?)

@ianestrachan
Copy link
Contributor Author

Well, if you have 30 volume worth of aspirin...

Anyway, let's try to get this into a concise list of steps:

  • Find items with vol <= amount you are over
    • If no such items exist, pick any random item, weighted by volume
  • Pick one item from the list of items that fit, weighted by volume, and drop it
  • Rinse and repeat until carried volume <= max volume

Something like that?

@kevingranade
Copy link
Member

Sounds ok to me. Not remotely ideal, but that would require pinning items
to containers, which we want to do, but that's a barrel of worms.

@raindropworks
Copy link
Contributor

on the +2 leeway, maybe make a random chance that something "falls out of your pack" since it was stuffed so full you couldn't close it? That's what I've seen the +2 as, is doing stupid stuff to get that last bit like leaving bags open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Enhancement / Feature> New features, or enhancements on existing (S2 - Confirmed) Bug that's been confirmed to exist <Suggestion / Discussion> Talk it out before implementing
Projects
None yet
Development

No branches or pull requests

3 participants